Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable testJoinDynamicFilteringMultiJoinOnBucketedTables in Iceberg #19095

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

krvikash
Copy link
Contributor

Description

Since Iceberg supports bucketing, So enable testJoinDynamicFilteringMultiJoinOnBucketedTables.

Release notes

(X) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2023
@github-actions github-actions bot added the iceberg Iceberg connector label Sep 19, 2023
@krvikash krvikash force-pushed the krvikash/iceberg-test-fix branch from 78a9de5 to bb0a477 Compare September 19, 2023 16:32
@krvikash krvikash force-pushed the krvikash/iceberg-test-fix branch from bb0a477 to cc448b3 Compare September 20, 2023 07:18
@krvikash
Copy link
Contributor Author

Thanks, @ebyhr for the review. Addressed comments.

@findepi findepi requested a review from sopel39 September 20, 2023 07:49
@sopel39
Copy link
Member

sopel39 commented Sep 20, 2023

I'm not sure this test is needed for Iceberg. I've added it to Hive to prove that deadlock was fixed, but only because there was no easy way to make such test in engine itself due to bucketing

@krvikash krvikash force-pushed the krvikash/iceberg-test-fix branch from cc448b3 to dadbfd4 Compare September 20, 2023 09:00
@krvikash
Copy link
Contributor Author

Thanks @findepi for the review. Addressed comments.

@findepi
Copy link
Member

findepi commented Sep 20, 2023

I'm not sure this test is needed for Iceberg.

I have no idea. But somehow we need to get rid of "Iceberg does not support bucketing" in the code, because it's not correct.

if @sopel39 the intention is to run the test for hive only, what about moving it to a hive-specific subclass?

Copy link
Member

@sopel39 sopel39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make sure it passes

@sopel39
Copy link
Member

sopel39 commented Sep 20, 2023

if @sopel39 the intention is to run the test for hive only, what about moving it to a hive-specific subclass?

Let's keep it as is since there is already abstraction createPartitionedAndBucketedTable for implementing it in different connectors

@findepi
Copy link
Member

findepi commented Sep 20, 2023

trino-google-sheets tests failed, rest is green

@findepi findepi merged commit 830c943 into trinodb:master Sep 20, 2023
@krvikash krvikash deleted the krvikash/iceberg-test-fix branch September 20, 2023 12:08
@github-actions github-actions bot added this to the 427 milestone Sep 20, 2023
@colebow
Copy link
Member

colebow commented Sep 25, 2023

I think you ticked the wrong release notes box. 😛

@colebow colebow added the no-release-notes This pull request does not require release notes entry label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

5 participants