-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable testJoinDynamicFilteringMultiJoinOnBucketedTables in Iceberg #19095
Conversation
78a9de5
to
bb0a477
Compare
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
bb0a477
to
cc448b3
Compare
Thanks, @ebyhr for the review. Addressed comments. |
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
...no-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergDynamicPartitionPruningTest.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseDynamicPartitionPruningTest.java
Show resolved
Hide resolved
I'm not sure this test is needed for Iceberg. I've added it to Hive to prove that deadlock was fixed, but only because there was no easy way to make such test in engine itself due to bucketing |
cc448b3
to
dadbfd4
Compare
Thanks @findepi for the review. Addressed comments. |
I have no idea. But somehow we need to get rid of if @sopel39 the intention is to run the test for hive only, what about moving it to a hive-specific subclass? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure it passes
Let's keep it as is since there is already abstraction |
|
I think you ticked the wrong release notes box. 😛 |
Description
Since Iceberg supports bucketing, So enable testJoinDynamicFilteringMultiJoinOnBucketedTables.
Release notes
(X) Release notes are required, with the following suggested text: