Update speculative flag in NodeLease for running tasks #19093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linzebing
approved these changes
Sep 19, 2023
arhimondr
approved these changes
Sep 19, 2023
| node = Futures.getDone(nodeLease.getNode()); | ||
| } | ||
| catch (ExecutionException e) { | ||
| throw new UncheckedExecutionException(e); |
There was a problem hiding this comment.
Maybe add a message to make it obvious that the nodeLease is expected to be "done" here
No, this is fine. The commits are not strictly related. |
We need to updated speculative flag in NodeLease objects which were already acquired. Flag impacts logic in BinPackingNodeAllocator. Without this change task which got its node while it was speculative still counted as speculative from NodeAllocator perspective even if it was already sealed.
63dcce6 to
73ed299
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We need to updated speculative flag in NodeLease objects which were
already acquired. Flag impacts logic in BinPackingNodeAllocator.
Without this change task which got its node while it was
speculative still counted as speculative from NodeAllocator perspective
even if it was already sealed.
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: