Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect banned imports #19089

Merged
merged 2 commits into from
Sep 19, 2023
Merged

Fix incorrect banned imports #19089

merged 2 commits into from
Sep 19, 2023

Conversation

wendigo
Copy link
Contributor

@wendigo wendigo commented Sep 19, 2023

No release notes needed

@cla-bot cla-bot bot added the cla-signed label Sep 19, 2023
ksobolew
ksobolew approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@ksobolew ksobolew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A silent conflict, I presume?

(Technically they are not yet banned, but they will be after an upgrade of Airbase, so)

@wendigo
Copy link
Contributor Author

wendigo commented Sep 19, 2023

@ksobolew actually it fails when I've used updated airbase with new enforcer plugin version

@wendigo wendigo requested a review from losipiuk September 19, 2023 10:29
@wendigo wendigo merged commit 41ddfd7 into trinodb:master Sep 19, 2023
@wendigo wendigo deleted the serafin/fix-banned-imports branch September 19, 2023 11:42
@github-actions github-actions bot added this to the 427 milestone Sep 19, 2023
@colebow colebow mentioned this pull request Sep 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksobolew ksobolew ksobolew approved these changes

@findepi findepi findepi approved these changes

@ebyhr ebyhr Awaiting requested review from ebyhr

@hashhar hashhar Awaiting requested review from hashhar

@losipiuk losipiuk Awaiting requested review from losipiuk

Assignees
No one assigned
Labels
cla-signed
Milestone
427
Development

Successfully merging this pull request may close these issues.
3 participants
@wendigo @findepi @ksobolew