Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable telemetry for JDBC connections #19021

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Temporarily disable telemetry for JDBC connections #19021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/DriverConnectionFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ public Connection openConnection(ConnectorSession session)
throws SQLException
{
Properties properties = getCredentialProperties(session.getIdentity());
Connection connection = dataSource.getConnection(properties);
// TODO: Telemetry is disabled due to NPE being thrown on null connection
// Connection connection = dataSource.getConnection(properties);
Connection connection = driver.connect(connectionUrl, properties);
checkState(connection != null, "Driver returned null connection, make sure the connection URL '%s' is valid for the driver %s", connectionUrl, driver);
return connection;
}
Expand Down