Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix elasticsearch like operator get utf8 character length error #18967

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

Jin-H
Copy link
Contributor

@Jin-H Jin-H commented Sep 8, 2023

Description

fix query elasticsearch using like operator when like content contains utf8 character like chinese

Additional context and related issues

Fixes #18966

Release notes

# Elasticsearch
Fix query failure when `LIKE` condition contains multi-byte characters. ({issue}`18966`)

@cla-bot
Copy link

cla-bot bot commented Sep 8, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Jin-H
Copy link
Contributor Author

Jin-H commented Sep 8, 2023

I have signed the cla and sent the mail. Please check.

@mosabua mosabua requested a review from martint September 8, 2023 17:29
Copy link
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you check and also file the CLA @martint ..

The other aspect that worries me is that this kind of problem might exist in a lot of other places. Do we need to check after this PR is merged or in parallel?

@ebyhr
Copy link
Member

ebyhr commented Sep 9, 2023

Do we need to check after this PR is merged or in parallel?

We can update BaseConnectorTest in a separated PR.

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Jin-H Jin-H changed the title Fix query elasticsearch using like operator when content is chinese c… Fix elasticsearch like operator utf8 character length error Sep 9, 2023
@Jin-H Jin-H changed the title Fix elasticsearch like operator utf8 character length error Fix elasticsearch like operator get utf8 character length error Sep 9, 2023
@cla-bot
Copy link

cla-bot bot commented Sep 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

1 similar comment
@cla-bot
Copy link

cla-bot bot commented Sep 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Sep 9, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@Jin-H
Copy link
Contributor Author

Jin-H commented Sep 11, 2023

@martint I have signed the cla and sent an email to cla@trino.io, can you help check it, thank you!

@Jin-H
Copy link
Contributor Author

Jin-H commented Sep 12, 2023

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

I submitted my CLA and it was approved.

@ebyhr
Copy link
Member

ebyhr commented Sep 12, 2023

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
@cla-bot
Copy link

cla-bot bot commented Sep 12, 2023

The cla-bot has been summoned, and re-checked this pull request!

@Jin-H
Copy link
Contributor Author

Jin-H commented Sep 12, 2023

@martint Can you help review it?

@ebyhr
Copy link
Member

ebyhr commented Sep 12, 2023

Please squash commits into one.

@Jin-H
Copy link
Contributor Author

Jin-H commented Sep 13, 2023

Please squash commits into one.

Already squashed.

@Jin-H Jin-H requested a review from ebyhr September 13, 2023 05:14
@martint martint merged commit 9d4c460 into trinodb:master Sep 13, 2023
@github-actions github-actions bot added this to the 427 milestone Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

elasticsearch connector encountered invalidUtf8Exception when using like operator
4 participants