Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add causing exception to Hudi metadata parsing error #18890

Merged

Conversation

atezs82
Copy link
Contributor

@atezs82 atezs82 commented Sep 1, 2023

Description

In case of a Hudi metadata corruption during reading replace commits, the exact exception is not logged in the error message, making it difficult to diagnose the actual problem. This PR aims to fix that with a very small code extension.

Additional context and related issues

When the filesystem view for a Hudi table is assembled in the Trino Hudi connector, replace commits need to be collected so that data is not read multiple times by the system. During this operation Hudi metadata for these commits is accessed and when it is not readable, the error message does not tell the actual reason. This PR is aiming to fix that.

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@atezs82 atezs82 force-pushed the add-underlying-exception-to-logged-error branch from d1400a5 to 1050876 Compare September 1, 2023 07:45
@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@github-actions github-actions bot added the hudi Hudi connector label Sep 1, 2023
@atezs82 atezs82 force-pushed the add-underlying-exception-to-logged-error branch from 1050876 to 00f45ab Compare September 1, 2023 07:50
@cla-bot cla-bot bot added the cla-signed label Sep 1, 2023
@atezs82 atezs82 force-pushed the add-underlying-exception-to-logged-error branch from 00f45ab to 7294b8d Compare September 1, 2023 07:53
@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Attila Tóth.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email email@example.com
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

@cla-bot cla-bot bot removed the cla-signed label Sep 1, 2023
@atezs82 atezs82 force-pushed the add-underlying-exception-to-logged-error branch from 7294b8d to 6dd030e Compare September 1, 2023 08:14
@cla-bot cla-bot bot added the cla-signed label Sep 1, 2023
@ebyhr ebyhr merged commit 470f666 into trinodb:master Sep 1, 2023
@github-actions github-actions bot added this to the 426 milestone Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed hudi Hudi connector
Development

Successfully merging this pull request may close these issues.

3 participants