Use OkHttp client in AzureFileSystem #18875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
add the context from the PR description into the commit message. |
2a148cc to
f61828b
Compare
|
@hashhar can you run this PR with secrets? |
|
/test-with-secrets sha=f61828bd1cc801e49cdbd92b1233985499bac4e3 |
|
The CI workflow run with tests that require additional secrets has been started: https://github.com/trinodb/trino/actions/runs/6046369673 |
wendigo
approved these changes
Sep 1, 2023
electrum
approved these changes
Sep 7, 2023
Switch to using the OkHttp client for the AzureFileSystem as it is lighter weight and serves the same purpose as the netty http client that is currently being used
f61828b to
a907801
Compare
electrum
approved these changes
Sep 7, 2023
in what way it's "lighter weight"? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch to using the OkHttp client for the AzureFileSystem as it is lighter weight and serves the same purpose as the netty http client that is currently being used
Additional context and related issues
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: