Extract methods to add system table entries #18857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c4225d6 to
e341668
Compare
losipiuk
approved these changes
Aug 30, 2023
losipiuk
reviewed
Aug 30, 2023
| }); | ||
|
|
||
| return displayTable.build().cursor(); | ||
| } | ||
|
|
||
| public void addMaterializedViewForCatalog(Session session, InMemoryRecordSet.Builder displayTable, QualifiedTablePrefix tablePrefix) |
There was a problem hiding this comment.
Extraction helper methods for clarity makes total sense. But please leave those as private as they are not used externally.
losipiuk
reviewed
Aug 30, 2023
core/trino-main/src/main/java/io/trino/connector/system/MaterializedViewSystemTable.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Aug 30, 2023
core/trino-main/src/main/java/io/trino/connector/system/TableCommentSystemTable.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Aug 30, 2023
| return table.build().cursor(); | ||
| } | ||
|
|
||
| public void addTableCommentForCatalog(Session session, Builder table, String catalog, QualifiedTablePrefix prefix) |
Extract individual catalog MV retrieval into method for clarity purposes
Extract individual catalog retrieval into method for clarity purposes
e341668 to
4fba3b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context and related issues
n/a
Release notes
(X) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: