Memory connector metadata fixes #18856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should `info` be null, code would fail before calling `checkState`.
losipiuk
reviewed
Aug 30, 2023
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Aug 30, 2023
0a07489 to
6dd34b0
Compare
losipiuk
reviewed
Aug 30, 2023
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
Outdated
Show resolved
Hide resolved
89309eb to
248f051
Compare
Avoiding IDE warning about redundant second `if`.
The related `ConnectorMetadata` methods are experimental.
`RelationCommentMetadata` is for relations, so if there was a `forTable` method, there should be a separate one for views as well.
248f051 to
e38dfd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.