Increase default response/request buffer size for OAuth2 client #18836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some of the identity providers the default buffer sizes are too small to work out of the box,
when authentication tokens size exceeds the default request buffer size of 4KB.
In these cases the default configuration will fail with:
```
io.trino.server.security.oauth2.NimbusAirliftHttpClient Received bad response from endpoint java.lang.IllegalArgumentException: Request header too large
at org.eclipse.jetty.client.http.HttpSenderOverHTTP$HeadersCallback.process(HttpSenderOverHTTP.java:182)
at org.eclipse.jetty.util.IteratingCallback.processing(IteratingCallback.java:232)
at org.eclipse.jetty.util.IteratingCallback.iterate(IteratingCallback.java:214)
at org.eclipse.jetty.client.http.HttpSenderOverHTTP.sendHeaders(HttpSenderOverHTTP.java:79)
at org.eclipse.jetty.client.HttpSender$ContentConsumer.onContent(HttpSender.java:496)
at org.eclipse.jetty.client.util.AbstractRequestContent$AbstractSubscription.notifyContent(AbstractRequestContent.java:207)
at org.eclipse.jetty.client.util.AbstractRequestContent$AbstractSubscription.processContent(AbstractRequestContent.java:181)
at org.eclipse.jetty.client.util.BytesRequestContent$SubscriptionImpl.produceContent(BytesRequestContent.java:83)
at org.eclipse.jetty.client.util.AbstractRequestContent$AbstractSubscription.produce(AbstractRequestContent.java:117)
at org.eclipse.jetty.client.util.AbstractRequestContent$AbstractSubscription.demand(AbstractRequestContent.java:93)
at org.eclipse.jetty.client.HttpSender.demand(HttpSender.java:237)
at org.eclipse.jetty.client.HttpSender.send(HttpSender.java:83)
at org.eclipse.jetty.client.http.HttpChannelOverHTTP.send(HttpChannelOverHTTP.java:80)
at org.eclipse.jetty.client.HttpChannel.send(HttpChannel.java:122)
at org.eclipse.jetty.client.HttpConnection.send(HttpConnection.java:111)
at org.eclipse.jetty.client.http.HttpConnectionOverHTTP$Delegate.send(HttpConnectionOverHTTP.java:301)
at org.eclipse.jetty.client.http.HttpConnectionOverHTTP.send(HttpConnectionOverHTTP.java:146)
at org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:440)
at org.eclipse.jetty.client.HttpDestination.process(HttpDestination.java:416)
at org.eclipse.jetty.client.HttpDestination.process(HttpDestination.java:371)
at org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:354)
at org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:348)
at org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:325)
at org.eclipse.jetty.client.HttpDestination.send(HttpDestination.java:304)
at org.eclipse.jetty.client.HttpClient.send(HttpClient.java:591)
at org.eclipse.jetty.client.HttpRequest.sendAsync(HttpRequest.java:819)
at org.eclipse.jetty.client.HttpRequest.send(HttpRequest.java:807)
at io.airlift.http.client.jetty.JettyHttpClient.execute(JettyHttpClient.java:578)
at io.trino.server.security.oauth2.NimbusAirliftHttpClient.execute(NimbusAirliftHttpClient.java:102)
at io.trino.server.security.oauth2.NimbusOAuth2Client.queryUserInfo(NimbusOAuth2Client.java:379)
at io.trino.server.security.oauth2.NimbusOAuth2Client.getJWTClaimsSet(NimbusOAuth2Client.java:371)
at io.trino.server.security.oauth2.NimbusOAuth2Client$OAuth2WithOidcExtensionsCodeFlow.toResponse(NimbusOAuth2Client.java:303)
at io.trino.server.security.oauth2.NimbusOAuth2Client$OAuth2WithOidcExtensionsCodeFlow.getOAuth2Response(NimbusOAuth2Client.java:285)
at io.trino.server.security.oauth2.NimbusOAuth2Client.getOAuth2Response(NimbusOAuth2Client.java:168)
at io.trino.server.security.oauth2.OAuth2Service.finishOAuth2Challenge(OAuth2Service.java:169)
at io.trino.server.security.oauth2.OAuth2CallbackResource.callback(OAuth2CallbackResource.java:71)
```
kokosing
approved these changes
Aug 28, 2023
lukasz-walkiewicz
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of the identity providers the default buffer sizes are too small to work out of the box, when authentication tokens size exceeds the default request buffer size of 4KB.
In these cases the default configuration will fail with:
Description
Additional context and related issues
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: