Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary purgeData parameter of TrinoCatalog.dropTable #11167

Merged
merged 1 commit into from
Feb 25, 2022
Merged

Remove unnecessary purgeData parameter of TrinoCatalog.dropTable #11167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergMetadata.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,7 +829,7 @@ public Optional<Object> getInfo(ConnectorTableHandle tableHandle)
@Override
public void dropTable(ConnectorSession session, ConnectorTableHandle tableHandle)
{
catalog.dropTable(session, ((IcebergTableHandle) tableHandle).getSchemaTableName(), true);
catalog.dropTable(session, ((IcebergTableHandle) tableHandle).getSchemaTableName());
}

@Override
Expand Down
2 changes: 1 addition & 1 deletion plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ Transaction newCreateTableTransaction(
String location,
Map<String, String> properties);

void dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData);
void dropTable(ConnectorSession session, SchemaTableName schemaTableName);

void renameTable(ConnectorSession session, SchemaTableName from, SchemaTableName to);

Expand Down
4 changes: 2 additions & 2 deletions plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/TrinoHiveCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ public List<SchemaTableName> listTables(ConnectorSession session, Optional<Strin
}

@Override
public void dropTable(ConnectorSession session, SchemaTableName schemaTableName, boolean purgeData)
public void dropTable(ConnectorSession session, SchemaTableName schemaTableName)
{
// TODO: support path override in Iceberg table creation: https://github.com/trinodb/trino/issues/8861
Table table = loadTable(session, schemaTableName);
Expand All @@ -304,7 +304,7 @@ public void dropTable(ConnectorSession session, SchemaTableName schemaTableName,
table.properties().containsKey(WRITE_METADATA_LOCATION)) {
throw new TrinoException(NOT_SUPPORTED, "Table " + schemaTableName + " contains Iceberg path override properties and cannot be dropped from Trino");
}
metastore.dropTable(schemaTableName.getSchemaName(), schemaTableName.getTableName(), purgeData);
metastore.dropTable(schemaTableName.getSchemaName(), schemaTableName.getTableName(), true);
}

@Override
Expand Down