Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ganglia metrics reporter for rubix #11101

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

raunaqmorarka
Copy link
Member

@raunaqmorarka raunaqmorarka commented Feb 18, 2022

Description

Ganglia metrics reporting does not work with the
custom hostnames generated by Trino. Disabling it
to avoid generating failures in logs.

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Hive cache

How would you describe this change to a non-technical end user or system administrator?

Avoids cluttering logs with failures about ganglia metrics

Related issues, pull requests, and links

https://trinodb.slack.com/archives/CGB0QHWSW/p1645125466118919

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

Ganglia metrics reporting does not work with the
custom hostnames generated by Trino. Disabling it
to avoid generating failures in logs.
@findepi findepi requested review from sopel39 and removed request for findepi February 18, 2022 14:41
@sopel39 sopel39 merged commit 921e189 into trinodb:master Feb 21, 2022
@sopel39 sopel39 mentioned this pull request Feb 21, 2022
@raunaqmorarka raunaqmorarka deleted the no-gang branch February 21, 2022 13:05
@github-actions github-actions bot added this to the 372 milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants