Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy ORC writer identification #10885

Conversation

findepi
Copy link
Member

@findepi findepi commented Feb 1, 2022

No description provided.

@findepi findepi requested a review from sopel39 February 1, 2022 10:20
@@ -56,8 +56,6 @@

// see https://github.com/trinodb/orc-protobuf/blob/master/src/main/protobuf/orc_proto.proto
public static final int PRESTO_WRITER_ID = 2;
// in order to change this value, the master Apache ORC proto file must be updated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it updated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no updated needed there

@findepi findepi marked this pull request as draft February 1, 2022 11:31
@findepi findepi force-pushed the findepi/remove-legacy-orc-writer-identification-407c40 branch from 4fc257e to 6fda258 Compare February 2, 2022 13:42
@cla-bot cla-bot bot added the cla-signed label Feb 2, 2022
@findepi findepi marked this pull request as ready for review February 25, 2022 21:42
@findepi findepi merged commit 8c59033 into trinodb:master Feb 25, 2022
@findepi findepi deleted the findepi/remove-legacy-orc-writer-identification-407c40 branch February 25, 2022 21:42
@findepi
Copy link
Member Author

findepi commented Feb 25, 2022

(no RN needed)

@github-actions github-actions bot added this to the 372 milestone Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants