Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JOIN pushdown for relational operators on varchar in PostgreSQL connector #10435

Closed
wants to merge 1 commit into from
Closed

Support JOIN pushdown for relational operators on varchar in PostgreSQL connector #10435

wants to merge 1 commit into from
+40 −10

Conversation

takezoe
Copy link
Member

@takezoe takezoe commented Dec 30, 2021 •
edited
Loading

Follow-up to #9746

@cla-bot cla-bot bot added the cla-signed label Dec 30, 2021
@takezoe takezoe changed the title Support order-denapdant JOIN pushdown for varchar in PostgreSQL connector Support JOIN pushdown for relational operators on varchar in PostgreSQL connector Dec 30, 2021
@hashhar
Copy link
Member

hashhar commented Dec 30, 2021

FYI @wendigo .

@hashhar
Copy link
Member

hashhar commented Dec 30, 2021

@takezoe See also #10059 for an alternative extension point which looks more flexible to me.

@takezoe
Copy link
Member Author

takezoe commented Dec 30, 2021

Oh, I see. Then, I would close this and wait for #10059.

@takezoe takezoe closed this Dec 30, 2021
@takezoe takezoe deleted the pgsql-varchar-join-pushdown branch December 30, 2021 07:25
@hashhar
Copy link
Member

hashhar commented Dec 30, 2021

#10059 only adds the extension point. There needs to be another PR built on top of it which uses the new functionality. I believe @wendigo was working on it.

@wendigo
Copy link
Contributor

wendigo commented Jan 3, 2022

I've implemented join pushdown for char types in PostgreSQL in #10059

@wendigo wendigo mentioned this pull request Jan 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takezoe @hashhar @wendigo