Add configuration property for max characters on alias column

trinodb · Aug 29, 2023 · 8fce268 · 8fce268
1 parent e36d9f5
commit 8fce268
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataConfig.java
@@ -41,6 +41,8 @@ public class JdbcMetadataConfig
     // between performance and pushdown capabilities
     private int domainCompactionThreshold = 32;
 
+    private int columnAliasMaxChars = 30;
+
     public boolean isComplexExpressionPushdownEnabled()
     {
         return complexExpressionPushdownEnabled;
@@ -100,6 +102,11 @@ public int getDomainCompactionThreshold()
         return domainCompactionThreshold;
     }
 
+    public int getColumnAliasMaxChars()
+    {
+        return this.columnAliasMaxChars;
+    }
+
     @Config("domain-compaction-threshold")
     @ConfigDescription("Maximum ranges to allow in a tuple domain without compacting it")
     public JdbcMetadataConfig setDomainCompactionThreshold(int domainCompactionThreshold)

diff --git a/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java b/plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/JdbcMetadataSessionProperties.java
@@ -36,6 +36,7 @@ public class JdbcMetadataSessionProperties
     public static final String AGGREGATION_PUSHDOWN_ENABLED = "aggregation_pushdown_enabled";
     public static final String TOPN_PUSHDOWN_ENABLED = "topn_pushdown_enabled";
     public static final String DOMAIN_COMPACTION_THRESHOLD = "domain_compaction_threshold";
+    public static final String COLUMN_ALIAS_MAX_CHARS = "column_alias_max_chars";
 
     private final List<PropertyMetadata<?>> properties;
 
@@ -70,6 +71,11 @@ public JdbcMetadataSessionProperties(JdbcMetadataConfig jdbcMetadataConfig, @Max
                         "Enable TopN pushdown",
                         jdbcMetadataConfig.isTopNPushdownEnabled(),
                         false))
+                .add(integerProperty(
+                        COLUMN_ALIAS_MAX_CHARS,
+                        "Maximum number of characters allowed in a column alias",
+                        jdbcMetadataConfig.getColumnAliasMaxChars(),
+                        false))
                 .build();
     }