Add ALTER TABLE SET PROPERTIES statement

trinodb · Oct 13, 2021 · 72df2b9 · 72df2b9
1 parent 1f31516
commit 72df2b9
Show file tree

Hide file tree

Showing 51 changed files with 575 additions and 16 deletions.
diff --git a/core/trino-main/src/main/java/io/trino/execution/AddColumnTask.java b/core/trino-main/src/main/java/io/trino/execution/AddColumnTask.java
@@ -114,7 +114,8 @@ public ListenableFuture<Void> execute(
                 session,
                 metadata,
                 accessControl,
-                parameterExtractor(statement, parameters));
+                parameterExtractor(statement, parameters),
+                true);
 
         ColumnMetadata column = ColumnMetadata.builder()
                 .setName(element.getName().getValue())

diff --git a/core/trino-main/src/main/java/io/trino/execution/CreateMaterializedViewTask.java b/core/trino-main/src/main/java/io/trino/execution/CreateMaterializedViewTask.java
@@ -110,7 +110,8 @@ public ListenableFuture<Void> execute(
                 session,
                 metadata,
                 accessControl,
-                parameterLookup);
+                parameterLookup,
+                true);
 
         ConnectorMaterializedViewDefinition definition = new ConnectorMaterializedViewDefinition(
                 sql,

diff --git a/core/trino-main/src/main/java/io/trino/execution/CreateSchemaTask.java b/core/trino-main/src/main/java/io/trino/execution/CreateSchemaTask.java
@@ -96,7 +96,8 @@ static ListenableFuture<Void> internalExecute(CreateSchema statement, Metadata m
                 session,
                 metadata,
                 accessControl,
-                parameterExtractor(statement, parameters));
+                parameterExtractor(statement, parameters),
+                true);
 
         TrinoPrincipal principal = getCreatePrincipal(statement, session, metadata, catalogName.getCatalogName());
         try {

diff --git a/core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java b/core/trino-main/src/main/java/io/trino/execution/CreateTableTask.java
@@ -155,7 +155,8 @@ ListenableFuture<Void> internalExecute(CreateTable statement, Metadata metadata,
                         session,
                         metadata,
                         accessControl,
-                        parameterLookup);
+                        parameterLookup,
+                        true);
 
                 columns.put(name, ColumnMetadata.builder()
                         .setName(name)
@@ -240,7 +241,8 @@ else if (element instanceof LikeClause) {
                 session,
                 metadata,
                 accessControl,
-                parameterLookup);
+                parameterLookup,
+                true);
 
         Map<String, Object> finalProperties = combineProperties(sqlProperties.keySet(), properties, inheritedProperties);
 

diff --git a/core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java b/core/trino-main/src/main/java/io/trino/execution/SetPropertiesTask.java
@@ -0,0 +1,102 @@
+/*
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package io.trino.execution;
+
+import com.google.common.util.concurrent.ListenableFuture;
+import io.trino.Session;
+import io.trino.execution.warnings.WarningCollector;
+import io.trino.metadata.Metadata;
+import io.trino.metadata.QualifiedObjectName;
+import io.trino.metadata.TableHandle;
+import io.trino.security.AccessControl;
+import io.trino.sql.tree.Expression;
+import io.trino.sql.tree.SetProperties;
+import io.trino.transaction.TransactionManager;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+
+import static com.google.common.util.concurrent.Futures.immediateVoidFuture;
+import static io.trino.metadata.MetadataUtil.createQualifiedObjectName;
+import static io.trino.metadata.MetadataUtil.getRequiredCatalogHandle;
+import static io.trino.spi.StandardErrorCode.NOT_SUPPORTED;
+import static io.trino.spi.StandardErrorCode.TABLE_NOT_FOUND;
+import static io.trino.sql.NodeUtils.mapFromProperties;
+import static io.trino.sql.ParameterUtils.parameterExtractor;
+import static io.trino.sql.analyzer.SemanticExceptions.semanticException;
+
+public class SetPropertiesTask
+        implements DataDefinitionTask<SetProperties>
+{
+    @Override
+    public String getName()
+    {
+        return "SET PROPERTIES";
+    }
+
+    @Override
+    public ListenableFuture<Void> execute(
+            SetProperties statement,
+            TransactionManager transactionManager,
+            Metadata metadata,
+            AccessControl accessControl,
+            QueryStateMachine stateMachine,
+            List<Expression> parameters,
+            WarningCollector warningCollector)
+    {
+        Session session = stateMachine.getSession();
+        QualifiedObjectName tableName = createQualifiedObjectName(session, statement, statement.getName());
+
+        Map<String, Expression> sqlProperties = mapFromProperties(statement.getProperties());
+
+        if (statement.getType() == SetProperties.Type.TABLE) {
+            Map<String, Object> properties = metadata.getTablePropertyManager().getProperties(
+                    getRequiredCatalogHandle(metadata, session, statement, tableName.getCatalogName()),
+                    tableName.getCatalogName(),
+                    sqlProperties,
+                    session,
+                    metadata,
+                    accessControl,
+                    parameterExtractor(statement, parameters),
+                    false); // skip setting of default properties since they should not be stored explicitly
+            setTableProperties(statement, tableName, metadata, accessControl, session, properties);
+        }
+        else {
+            throw semanticException(NOT_SUPPORTED, statement, "Unsupported target type: %s", statement.getType());
+        }
+
+        return immediateVoidFuture();
+    }
+
+    private void setTableProperties(SetProperties statement, QualifiedObjectName tableName, Metadata metadata, AccessControl accessControl, Session session, Map<String, Object> properties)
+    {
+        if (metadata.getMaterializedView(session, tableName).isPresent()) {
+            throw semanticException(NOT_SUPPORTED, statement, "Cannot set properties to a materialized view in ALTER TABLE");
+        }
+
+        if (metadata.getView(session, tableName).isPresent()) {
+            throw semanticException(NOT_SUPPORTED, statement, "Cannot set properties to a view in ALTER TABLE");
+        }
+
+        Optional<TableHandle> tableHandle = metadata.getTableHandle(session, tableName);
+        if (tableHandle.isEmpty()) {
+            throw semanticException(TABLE_NOT_FOUND, statement, "Table does not exist: %s", tableName);
+        }
+
+        accessControl.checkCanSetTableProperties(session.toSecurityContext(), tableName, properties);
+
+        metadata.setTableProperties(session, tableHandle.get(), properties);
+    }
+}
diff --git a/core/trino-main/src/main/java/io/trino/metadata/AbstractPropertyManager.java b/core/trino-main/src/main/java/io/trino/metadata/AbstractPropertyManager.java
@@ -77,7 +77,8 @@ public final Map<String, Object> getProperties(
             Session session,
             Metadata metadata,
             AccessControl accessControl,
-            Map<NodeRef<Parameter>, Expression> parameters)
+            Map<NodeRef<Parameter>, Expression> parameters,
+            boolean setDefaultProperties)
     {
         Map<String, PropertyMetadata<?>> supportedProperties = connectorProperties.get(catalogName);
         if (supportedProperties == null) {
@@ -134,6 +135,9 @@ public final Map<String, Object> getProperties(
         }
         Map<String, Object> userSpecifiedProperties = properties.build();
 
+        if (!setDefaultProperties) {
+            return properties.build();
+        }
         // Fill in the remaining properties with non-null defaults
         for (PropertyMetadata<?> propertyMetadata : supportedProperties.values()) {
             if (!userSpecifiedProperties.containsKey(propertyMetadata.getName())) {

diff --git a/core/trino-main/src/main/java/io/trino/metadata/Metadata.java b/core/trino-main/src/main/java/io/trino/metadata/Metadata.java
@@ -200,6 +200,11 @@ public interface Metadata
      */
     void renameTable(Session session, TableHandle tableHandle, QualifiedObjectName newTableName);
 
+    /**
+     * Set properties to the specified table.
+     */
+    void setTableProperties(Session session, TableHandle tableHandle, Map<String, Object> properties);
+
     /**
      * Comments to the specified table.
      */

diff --git a/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java b/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
@@ -773,6 +773,14 @@ public void renameTable(Session session, TableHandle tableHandle, QualifiedObjec
         metadata.renameTable(session.toConnectorSession(catalog), tableHandle.getConnectorHandle(), newTableName.asSchemaTableName());
     }
 
+    @Override
+    public void setTableProperties(Session session, TableHandle tableHandle, Map<String, Object> properties)
+    {
+        CatalogName catalogName = tableHandle.getCatalogName();
+        ConnectorMetadata metadata = getMetadataForWrite(session, catalogName);
+        metadata.setTableProperties(session.toConnectorSession(catalogName), tableHandle.getConnectorHandle(), properties);
+    }
+
     @Override
     public void setTableComment(Session session, TableHandle tableHandle, Optional<String> comment)
     {

diff --git a/core/trino-main/src/main/java/io/trino/security/AccessControl.java b/core/trino-main/src/main/java/io/trino/security/AccessControl.java
@@ -27,6 +27,7 @@
 
 import java.security.Principal;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 
@@ -180,6 +181,13 @@ public interface AccessControl
      */
     void checkCanRenameTable(SecurityContext context, QualifiedObjectName tableName, QualifiedObjectName newTableName);
 
+    /**
+     * Check if identity is allowed to set properties to the specified table.
+     *
+     * @throws AccessDeniedException if not allowed
+     */
+    void checkCanSetTableProperties(SecurityContext context, QualifiedObjectName tableName, Map<String, Object> properties);
+
     /**
      * Check if identity is allowed to comment the specified table.
      *

diff --git a/core/trino-main/src/main/java/io/trino/security/AccessControlManager.java b/core/trino-main/src/main/java/io/trino/security/AccessControlManager.java
@@ -453,6 +453,20 @@ public void checkCanRenameTable(SecurityContext securityContext, QualifiedObject
         catalogAuthorizationCheck(tableName.getCatalogName(), securityContext, (control, context) -> control.checkCanRenameTable(context, tableName.asSchemaTableName(), newTableName.asSchemaTableName()));
     }
 
+    @Override
+    public void checkCanSetTableProperties(SecurityContext securityContext, QualifiedObjectName tableName, Map<String, Object> properties)
+    {
+        requireNonNull(securityContext, "securityContext is null");
+        requireNonNull(tableName, "tableName is null");
+        requireNonNull(properties, "properties is null");
+
+        checkCanAccessCatalog(securityContext, tableName.getCatalogName());
+
+        systemAuthorizationCheck(control -> control.checkCanSetTableProperties(securityContext.toSystemSecurityContext(), tableName.asCatalogSchemaTableName(), properties));
+
+        catalogAuthorizationCheck(tableName.getCatalogName(), securityContext, (control, context) -> control.checkCanSetTableProperties(context, tableName.asSchemaTableName(), properties));
+    }
+
     @Override
     public void checkCanSetTableComment(SecurityContext securityContext, QualifiedObjectName tableName)
     {

diff --git a/core/trino-main/src/main/java/io/trino/security/AllowAllAccessControl.java b/core/trino-main/src/main/java/io/trino/security/AllowAllAccessControl.java
@@ -22,6 +22,7 @@
 import io.trino.spi.security.TrinoPrincipal;
 
 import java.security.Principal;
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 
@@ -131,6 +132,11 @@ public void checkCanRenameTable(SecurityContext context, QualifiedObjectName tab
     {
     }
 
+    @Override
+    public void checkCanSetTableProperties(SecurityContext context, QualifiedObjectName tableName, Map<String, Object> properties)
+    {
+    }
+
     @Override
     public void checkCanSetTableComment(SecurityContext context, QualifiedObjectName tableName)
     {

diff --git a/core/trino-main/src/main/java/io/trino/security/DenyAllAccessControl.java b/core/trino-main/src/main/java/io/trino/security/DenyAllAccessControl.java
@@ -23,6 +23,7 @@
 import io.trino.spi.security.TrinoPrincipal;
 
 import java.security.Principal;
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 
@@ -68,6 +69,7 @@
 import static io.trino.spi.security.AccessDeniedException.denySetSchemaAuthorization;
 import static io.trino.spi.security.AccessDeniedException.denySetSystemSessionProperty;
 import static io.trino.spi.security.AccessDeniedException.denySetTableAuthorization;
+import static io.trino.spi.security.AccessDeniedException.denySetTableProperties;
 import static io.trino.spi.security.AccessDeniedException.denySetUser;
 import static io.trino.spi.security.AccessDeniedException.denySetViewAuthorization;
 import static io.trino.spi.security.AccessDeniedException.denyShowColumns;
@@ -194,6 +196,12 @@ public void checkCanRenameTable(SecurityContext context, QualifiedObjectName tab
         denyRenameTable(tableName.toString(), newTableName.toString());
     }
 
+    @Override
+    public void checkCanSetTableProperties(SecurityContext context, QualifiedObjectName tableName, Map<String, Object> properties)
+    {
+        denySetTableProperties(tableName.toString());
+    }
+
     @Override
     public void checkCanSetTableComment(SecurityContext context, QualifiedObjectName tableName)
     {

diff --git a/core/trino-main/src/main/java/io/trino/security/ForwardingAccessControl.java b/core/trino-main/src/main/java/io/trino/security/ForwardingAccessControl.java
@@ -25,6 +25,7 @@
 
 import java.security.Principal;
 import java.util.List;
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 import java.util.function.Supplier;
@@ -170,6 +171,12 @@ public void checkCanRenameTable(SecurityContext context, QualifiedObjectName tab
         delegate().checkCanRenameTable(context, tableName, newTableName);
     }
 
+    @Override
+    public void checkCanSetTableProperties(SecurityContext context, QualifiedObjectName tableName, Map<String, Object> properties)
+    {
+        delegate().checkCanSetTableProperties(context, tableName, properties);
+    }
+
     @Override
     public void checkCanSetTableComment(SecurityContext context, QualifiedObjectName tableName)
     {

diff --git a/core/trino-main/src/main/java/io/trino/security/InjectedConnectorAccessControl.java b/core/trino-main/src/main/java/io/trino/security/InjectedConnectorAccessControl.java
@@ -26,6 +26,7 @@
 import io.trino.spi.security.ViewExpression;
 import io.trino.spi.type.Type;
 
+import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
 
@@ -124,6 +125,13 @@ public void checkCanRenameTable(ConnectorSecurityContext context, SchemaTableNam
         accessControl.checkCanRenameTable(securityContext, getQualifiedObjectName(tableName), getQualifiedObjectName(tableName));
     }
 
+    @Override
+    public void checkCanSetTableProperties(ConnectorSecurityContext context, SchemaTableName tableName, Map<String, Object> properties)
+    {
+        checkArgument(context == null, "context must be null");
+        accessControl.checkCanSetTableProperties(securityContext, getQualifiedObjectName(tableName), properties);
+    }
+
     @Override
     public void checkCanSetTableComment(ConnectorSecurityContext context, SchemaTableName tableName)
     {

diff --git a/core/trino-main/src/main/java/io/trino/server/QueryExecutionFactoryModule.java b/core/trino-main/src/main/java/io/trino/server/QueryExecutionFactoryModule.java
@@ -50,6 +50,7 @@
 import io.trino.execution.RevokeTask;
 import io.trino.execution.RollbackTask;
 import io.trino.execution.SetPathTask;
+import io.trino.execution.SetPropertiesTask;
 import io.trino.execution.SetRoleTask;
 import io.trino.execution.SetSchemaAuthorizationTask;
 import io.trino.execution.SetSessionTask;
@@ -88,6 +89,7 @@
 import io.trino.sql.tree.RevokeRoles;
 import io.trino.sql.tree.Rollback;
 import io.trino.sql.tree.SetPath;
+import io.trino.sql.tree.SetProperties;
 import io.trino.sql.tree.SetRole;
 import io.trino.sql.tree.SetSchemaAuthorization;
 import io.trino.sql.tree.SetSession;
@@ -146,6 +148,7 @@ public void configure(Binder binder)
         bindDataDefinitionTask(binder, executionBinder, RevokeRoles.class, RevokeRolesTask.class);
         bindDataDefinitionTask(binder, executionBinder, Rollback.class, RollbackTask.class);
         bindDataDefinitionTask(binder, executionBinder, SetPath.class, SetPathTask.class);
+        bindDataDefinitionTask(binder, executionBinder, SetProperties.class, SetPropertiesTask.class);
         bindDataDefinitionTask(binder, executionBinder, SetTimeZone.class, SetTimeZoneTask.class);
         bindDataDefinitionTask(binder, executionBinder, SetRole.class, SetRoleTask.class);
         bindDataDefinitionTask(binder, executionBinder, SetSchemaAuthorization.class, SetSchemaAuthorizationTask.class);

diff --git a/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java b/core/trino-main/src/main/java/io/trino/sql/analyzer/StatementAnalyzer.java
@@ -157,6 +157,7 @@
 import io.trino.sql.tree.Select;
 import io.trino.sql.tree.SelectItem;
 import io.trino.sql.tree.SetOperation;
+import io.trino.sql.tree.SetProperties;
 import io.trino.sql.tree.SetSchemaAuthorization;
 import io.trino.sql.tree.SetSession;
 import io.trino.sql.tree.SetTableAuthorization;
@@ -726,7 +727,8 @@ protected Scope visitAnalyze(Analyze node, Optional<Scope> scope)
                     session,
                     metadata,
                     accessControl,
-                    analysis.getParameters());
+                    analysis.getParameters(),
+                    true);
             TableHandle tableHandle = metadata.getTableHandleForStatisticsCollection(session, tableName, analyzeProperties)
                     .orElseThrow(() -> semanticException(TABLE_NOT_FOUND, node, "Table '%s' does not exist", tableName));
 
@@ -815,7 +817,8 @@ protected Scope visitCreateTableAsSelect(CreateTableAsSelect node, Optional<Scop
                     session,
                     metadata,
                     accessControl,
-                    analysis.getParameters());
+                    analysis.getParameters(),
+                    true);
 
             ConnectorTableMetadata tableMetadata = new ConnectorTableMetadata(targetTable.asSchemaTableName(), columns.build(), properties, node.getComment());
 
@@ -951,6 +954,12 @@ protected Scope visitRenameTable(RenameTable node, Optional<Scope> scope)
             return createAndAssignScope(node, scope);
         }
 
+        @Override
+        protected Scope visitSetProperties(SetProperties node, Optional<Scope> context)
+        {
+            return createAndAssignScope(node, context);
+        }
+
         @Override
         protected Scope visitComment(Comment node, Optional<Scope> scope)
         {