Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Spooling Protocol #509

Merged
merged 4 commits into from
Jan 13, 2025
Merged

Conversation

mdesmet
Copy link
Contributor

@mdesmet mdesmet commented Jan 2, 2025

Description

Support Spooling Protocol

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(*) Release notes are required, with the following suggested text:

* Support Spooling Protocol

@cla-bot cla-bot bot added the cla-signed label Jan 2, 2025
@mdesmet mdesmet requested review from wendigo, aalbu and hashhar January 2, 2025 02:59
@wendigo
Copy link

wendigo commented Jan 2, 2025

Thanks @mdesmet

@mdesmet mdesmet requested a review from mosabua January 2, 2025 05:39
@wendigo
Copy link

wendigo commented Jan 2, 2025

@hashhar ptal

Copy link
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions and comments

tests/development_server.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/client.py Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/client.py Outdated Show resolved Hide resolved
trino/dbapi.py Show resolved Hide resolved
@mdesmet mdesmet force-pushed the feat/spooled-protocol branch from 625c4dc to f803be3 Compare January 12, 2025 13:22
@mdesmet mdesmet force-pushed the feat/spooled-protocol branch from f803be3 to ecd65e8 Compare January 12, 2025 13:27
@mdesmet mdesmet force-pushed the feat/spooled-protocol branch from ecd65e8 to 072b5e6 Compare January 12, 2025 13:35
@mdesmet
Copy link
Contributor Author

mdesmet commented Jan 12, 2025

@hashhar : PTAL, I processed all comments.

@hashhar hashhar merged commit 3a9de8b into trinodb:master Jan 13, 2025
12 checks passed
@wendigo
Copy link

wendigo commented Jan 13, 2025

Thanks @mdesmet for bringing this to completion. Great work 🎉

@mosabua
Copy link
Member

mosabua commented Jan 13, 2025

Awesome work @mdesmet!

I created a PR to add the Python client to the Trino docs at trinodb/trino#24697

We can merge that once the Python client release is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants