Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor get_indexes to return partition names and values #486

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

damian3031
Copy link
Member

Description

Resolves #476
get_indexes refactored to return list of dicts with partition name and partition values.
example output:

[
    {
        'partition_name': 'part_a',
        'partition_values': ['val1', 'val2', 'val3']
    },
    {
        'partition_name': 'part_b',
        'partition_values': ['val4', 'val5', 'val6']
    }
]

Non-technical explanation

Release notes

( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Sep 25, 2024
@damian3031 damian3031 requested a review from hashhar September 25, 2024 21:38
trino/sqlalchemy/dialect.py Outdated Show resolved Hide resolved
@damian3031 damian3031 force-pushed the damian/refactor-get-indexes branch from c5b3711 to 4d90a35 Compare September 26, 2024 09:48
@hashhar hashhar merged commit d88f476 into trinodb:master Sep 26, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Incorrect retrieval of partitions in get_indexes method
3 participants