Fix JSON support in SQLAlchemy #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdesmet
approved these changes
Nov 28, 2023
d99fcaf to
594782c
Compare
hashhar
reviewed
Nov 28, 2023
trino/sqlalchemy/datatype.py
Outdated
| return "$%s" % ( | ||
| "".join( | ||
| [ | ||
| "[%s]" % elem if isinstance(elem, int) else '.%s' % elem |
There was a problem hiding this comment.
why not quote with [ always? e.g. if elem has a dash then also you need to quote.
There was a problem hiding this comment.
also maybe extract a well-named static method for this
594782c to
f7eff9f
Compare
hashhar
approved these changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #423 and #387
Non-technical explanation
Release notes
( ) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text: