Add JSON functionality to SQLAlchemy Dialect #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hovaesco
reviewed
Aug 17, 2022
mdesmet
reviewed
Aug 17, 2022
hovaesco
reviewed
Aug 30, 2022
mdesmet
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
@laserkaplan: please have a look at the pending remark of @hovaesco on moving the TypeDecorator to datatype.py.
LGTM % the above remark and squash the commits.
|
Whoops, thanks for the reminder! Moved to |
|
Seems like these tests failing might be a larger issue? Multiple open PRs are all failing at the same spot. |
Yes, it should be gone when #220 is merged. |
be7788c to
cc42f4e
Compare
hashhar
approved these changes
Sep 20, 2022
There was a problem hiding this comment.
I'll rebase and then merge this after I merge #220 tomorrow morning my time.
Thanks for contributing @laserkaplan and sorry about the very long delay.
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement the ability to reference JSON columns using SQLAlchemy. This allows JSON columns to be created in new tables, as well as writes to/reads from them using normal Python
jsonmodule serialization/deserialization.Originally referenced in this issue.
Release notes
( ) This is not user-visible and no release notes are required.
( ) Release notes are required, please propose a release note for me.
(x) Release notes are required, with the following suggested text: