Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Phoenix version in docker image to 5.2.1 #220

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

virajjasani
Copy link
Member

No description provided.

Copy link

cla-bot bot commented Dec 18, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@ebyhr
Copy link
Member

ebyhr commented Jan 13, 2025

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 13, 2025
Copy link

cla-bot bot commented Jan 13, 2025

The cla-bot has been summoned, and re-checked this pull request!

@ebyhr
Copy link
Member

ebyhr commented Jan 13, 2025

@virajjasani Did you run Trino product tests with this PR?

@virajjasani
Copy link
Member Author

virajjasani commented Jan 14, 2025

@ebyhr please pardon my ignorance, but could you please point me to doc or instructions reg the local test setup required to do product test using local images? I tried building image with make testing/phoenix5.dependants. Now i need to test but not perform release steps as they would actually release the image to docker hub right?

@ebyhr ebyhr merged commit 989ea91 into trinodb:master Jan 14, 2025
6 of 8 checks passed
@ebyhr
Copy link
Member

ebyhr commented Jan 14, 2025

I confirmed the product test result in my laptop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants