Tpetra: Fix build warnings #4556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2019 21:10
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.8.4 # 2692 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_intel_17.0.1 # 2493 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_4.9.3_SERIAL # 980 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_gcc_7.2.0 # 664 (click to expand)Console Output (last 100 lines) : Trilinos_pullrequest_cuda_9.2 # 406 (click to expand) |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
There was a problem hiding this comment.
Most of the changes are pretty straightforward here. Looks like the removal of unused symbols, etc. However, there are some changes in the functions and operations that are called. In one case, a deep copy of a map is performed followed by some other operations. It might be good for another Tpetra developer to look at that stuff carefully.
@mhoemmen, I will approve this PR without another Tpetra developer approving it if you are confident in these changes. Just ask.
| typedef Map<LO, GO, NT> map_type; | ||
|
|
||
| RCP<const map_type> newMap = input->getMap ()->removeEmptyProcesses (); | ||
| auto newMap = input->getMap ()->removeEmptyProcesses (); |
| @@ -155,21 +155,29 @@ namespace { // (anonymous) | |||
| * the number of replaced diagonal entries to match the | |||
| * local number of rows. | |||
| */ | |||
| TEST_EQUALITY(numReplacedDiagEntries, matrix->getNodeNumRows()); | |||
| const LO lclNumRows = static_cast<LO> (matrix->getNodeNumRows ()); | |||
| TEST_EQUALITY(numReplacedDiagEntries, lclNumRows); | |||
There was a problem hiding this comment.
Does this indentation not quite line up here? Looks like TEST_EQUALITY() is indented one space too many.
|
|
||
| for (size_t i = 0; i < diagCopyData.size(); ++i) | ||
| TEST_EQUALITY_CONST(diagCopyData[i], rankAsScalar); | ||
| vec_type diagCopy (matrix->getRowMap ()); |
There was a problem hiding this comment.
deep copy of the row map?
There was a problem hiding this comment.
@bartlettroscoe Nope -- getRowMap() returns RCP<const Map>.
There was a problem hiding this comment.
Right. I forgot Tpetra moved to shallow copy semantics.
|
Status Flag 'Pull Request AutoTester' - Error: Jenkins Jobs - Error: [Jenkins] Cannot retrieve build running status on build (FATAL: ERROR : [jwrap: build.is_running():788:./support/jenkins_support.py] - General Exception: (HTTPSConnectionPool(host='ascic-jenkins.sandia.gov', port=443): Max retries exceeded with url: /job/trilinos-folder/job/Trilinos_pullrequest_gcc_4.9.3_SERIAL/986/api/python?depth=1&tree=building (Caused by ReadTimeoutError("HTTPSConnectionPool(host='ascic-jenkins.sandia.gov', port=443): Read timed out. (read timeout=60)",)))) |
|
@bartlettroscoe It's OK to approve, but if you feel better letting somebody else do it, feel free. Thanks! |
bartlettroscoe
approved these changes
Mar 6, 2019
There was a problem hiding this comment.
@mhoemmen said:
@bartlettroscoe It's OK to approve, but if you feel better letting somebody else do it, feel free. Thanks!
I think the risk is pretty small and hopefully the PR tests would catch any problems. Therefore, I will approve.
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
Using Repos:
Pull Request Author: mhoemmen |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3_SERIAL
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_7.2.0
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_cuda_9.2
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ bartlettroscoe ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged |
|
Merge on Pull Request# 4556: IS A SUCCESS - Pull Request successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/tpetra @trilinos/framework
Fix some Tpetra build warnings that block building with warnings as errors.