-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Framework: PR testing changed packages #3218
Framework: PR testing changed packages #3218
Conversation
Modify PR test driver to use Ross's changed-packages script
The |
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yo delete the "nurgleflurgle" we gotta be boring in Trilinos ;-)
@@ -134,6 +127,18 @@ then | |||
echo "There was an issue loading the intel environment. The error code was: $ierror" | |||
exit $ierror | |||
fi | |||
# --- BEGIN SCAFFOLDING --- | |||
# nurgleflurgle... name match! can we change this to a regex or something to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nurgleflurgle"?
elif [ "Trilinos_pullrequest_gcc_4.9.3" == "${JOB_BASE_NAME:?}" ]; then | ||
CONFIG_SCRIPT=PullRequestLinuxGCC4.9.3TestingSettings.cmake | ||
# --- BEGIN SCAFFOLDING --- | ||
# nurgleflurgle... name match! can we change this to a regex or something to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"nurgleflurgle"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hah... as noted in my 1st comment -- all the stuff in scaffolding
blocks will be removed before merging. This was just in there because the testing scripts do a name-match on the Jenkins job... once the framework team is ready to merge this in, I'll remove those comment blocks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok "nurgleflurgle" is harmless never mind :)
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Using Repos:
Pull Request Author: william76 |
NOTICE: The AutoTester has encountered an internal error (usually a Communications Timeout), testing will be restarted, previous tests may still be running but will be ignored by the AutoTester... |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Using Repos:
Pull Request Author: william76 |
# - One of the SEMS modules will load CMake 3.4.x also, | ||
# so this will pull in the SEMS cmake 3.10.3 version | ||
# for Trilinos compatibility. | ||
module load sems-cmake/3.10.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Loaded CMake module twice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just saw the one double module load. Other than that, these changes look good.
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
|
@jwillenbring removed the duplicate sems-cmake/3.10.3 load from the GCC 4.8.4 driver script. |
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
Using Repos:
Pull Request Author: william76 |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_pullrequest_gcc_4.9.3
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_gcc_4.8.4
Jenkins Parameters
Build InformationTest Name: Trilinos_pullrequest_intel_17.0.1
Jenkins Parameters
|
Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur... |
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mhoemmen ]! |
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for making the minor change.
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
2 similar comments
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
@mhoemmen why did you merge this in!? From my comments above:
In this case, the intent of the framework team, since 3 of us were gone late last week, was to review this PR on Monday and decide to merge it in after our stand up meeting if we liked it, and after I pulled the scaffolding comments out first. We wanted the PR in so we could look at it and review. In the future, please hold back on merging Framework team PR's since we generally have a specific timing in mind for when we click the button to make sure that we're around and paying close attention to testing, etc. in case things woof. ;) |
@william76 Sorry, I was on autopilot. I'll let y'all do this next time. My bad :) |
@trilinos/framework
Description
Update to PR Autotester scripts to use the Tribits based changed-packages utility to create a
packageEnables.cmake
file.Motivation and Context
The current auto-tester defaults to a more conservative model of selecting packages to enable in testing. This can result in long test times for trivial changes such as modifying some ctest drivers, etc. when we would not need to retest everything in that situation.
This update will reduce some of these testing times by using the Tribits/CMake infrastructure to more accurately determine which packages need to be built based on the files that are changed between
develop
and the source branch.Relates to #3133
How Has This Been Tested?
I ran these tests on Jenkins to test the changes for the GCC 4.9.3 compiler: