Modify the getNodalFieldSolution function in FEI. #1992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change, the nodal loop would continue if the node was a shared node and was not attached to the local element. This continue was causing issues in parallel when the nodal data was being synched across processor after a FETI solve when the run involved element death. This created many issues and support tickets we have been working through for a long time. This was a great team effort with Alan, Kendall, Mike, and Patrick. Alan and Kendall will work on pushing this change to Trilinos.
|
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
jwillenbring
approved these changes
Nov 16, 2017
|
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jwillenbring ]! |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTINGBuild Information
Jenkins Parameters
Build Information
Jenkins Parameters
Using Repos:
Pull Request Author: alanw0 |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSEDBuild Information
Jenkins Parameters
Build Information
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ jwillenbring ]! |
|
Status Flag 'Pull Request AutoTester' - Pull Request MUST BE MERGED MANUALLY BY Project Team - Master Automerge is disabled (in .cfg file) |
|
These changes fixed an issue for an important customer and passed the pull request testing. I am going to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change, the nodal loop would continue if the node was
a shared node and was not attached to the local element. This continue
was causing issues in parallel when the nodal data was being synched across
processor after a FETI solve when the run involved element death.
This created many issues and support tickets in the Sierra system that
we have been working through for a long time.
This was a great team effort with Alan, Kendall, Mike, and Patrick.
Alan and Kendall will work on pushing this change to Trilinos.
@trilinos/fei
Description
Motivation and Context
Related Issues
How Has This Been Tested?
Screenshots
Checklist
Additional Information