Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOX: Reuse prec across multiple nonlinear solves #12986

Merged
merged 1 commit into from
May 3, 2024
Merged

NOX: Reuse prec across multiple nonlinear solves #12986

merged 1 commit into from
May 3, 2024

Conversation

rppawlo
Copy link
Contributor

@rppawlo rppawlo commented May 3, 2024

Motivation

For efficiency, one might want to reuse the preconditioner over multiple nonlinear solves. If we have multiple stages in a DIRK method, this can be useful for reusing the same preconditioner for all solves within the time step. Previous work allowed reuse within a nonlinear solve. This adds reuse across multiple nonlinear solves.

Stakeholder Feedback

Testing

new tests added to tpetra 1dfem

@rppawlo rppawlo added pkg: NOX AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. labels May 3, 2024
@rppawlo rppawlo self-assigned this May 3, 2024
@rppawlo rppawlo requested a review from a team as a code owner May 3, 2024 16:46
@rppawlo rppawlo requested a review from etphipp May 3, 2024 16:46
@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects:

Pull Request Auto Testing STARTING (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 4063
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any&&!sandybridge
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 2562
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 2552
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 2551
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 3709
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 3554
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 2193
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

  • Build Num: 288
  • Status: STARTED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Using Repos:

Repo: TRILINOS (rppawlo/Trilinos)
  • Branch: nox-reuse-prec-nl-solves
  • SHA: 4abb07e
  • Mode: TEST_REPO

Pull Request Author: rppawlo

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED

Pull Request Auto Testing has PASSED (click to expand)

Build Information

Test Name: Trilinos_PR_gcc-8.3.0

  • Build Num: 4063
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-openmp_release-debug_static_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any&&!sandybridge
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-serial

  • Build Num: 2562
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-v2-gnu-8.3.0-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_gcc-8.3.0-debug

  • Build Num: 2552
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-8.3.0-openmpi-1.10.1-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_clang-11.0.1

  • Build Num: 2551
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-clang-11.0.1-openmpi-1.10.1-serial_release-debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_python3

  • Build Num: 3709
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-gnu-7.2.0-anaconda3-serial_debug_shared_no-kokkos-arch_no-asan_no-complex_no-fpic_no-mpi_no-pt_no-rdc_no-uvm_deprecated-on_pr-framework
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL ascic
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_cuda-11.4.2-uvm-off

  • Build Num: 3554
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_no-uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL GPU
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_intel-2021.3

  • Build Num: 2193
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-intel-2021.3-sems-openmpi-4.0.5_release-debug_shared_no-kokkos-arch_no-asan_no-complex_fpic_mpi_no-pt_no-rdc_no-uvm_deprecated-off_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404

Build Information

Test Name: Trilinos_PR_cuda-11.4.20-uvm

  • Build Num: 288
  • Status: PASSED

Jenkins Parameters

Parameter Name Value
FORCE_CLEAN true
GENCONFIG_BUILD_NAME rhel7_sems-cuda-11.4.2-sems-gnu-10.1.0-sems-openmpi-4.0.5_release_static_Volta70_no-asan_complex_no-fpic_mpi_pt_no-rdc_uvm_deprecated-on_no-package-enables
PR_LABELS pkg: NOX;AT: AUTOMERGE;PA: Nonlinear Solvers;AT: PRE-TEST INSPECTED
PULLREQUESTNUM 12986
PULLREQUEST_CDASH_TRACK Pull Request
TEST_REPO_ALIAS TRILINOS
TRILINOS_NODE_LABEL trilinos-any
TRILINOS_SOURCE_REPO https://github.com/rppawlo/Trilinos
TRILINOS_SOURCE_SHA 4abb07e
TRILINOS_SRN_CONFIG true
TRILINOS_TARGET_BRANCH develop
TRILINOS_TARGET_REPO https://github.com/trilinos/Trilinos
TRILINOS_TARGET_SHA dd6e404


CDash Test Results for PR# 12986.

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging
NO REVIEWS HAVE BEEN PERFORMED ON THIS PULL REQUEST!

@trilinos-autotester
Copy link
Contributor

All Jobs Finished; status = PASSED, However Inspection must be performed before merge can occur...

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ etphipp ]!

@trilinos-autotester
Copy link
Contributor

Status Flag 'Pull Request AutoTester' - Pull Request will be Automerged

@trilinos-autotester trilinos-autotester merged commit f0c4085 into trilinos:develop May 3, 2024
15 checks passed
@trilinos-autotester
Copy link
Contributor

Merge on Pull Request# 12986: IS A SUCCESS - Pull Request successfully merged

@trilinos-autotester trilinos-autotester removed the AT: AUTOMERGE Causes the PR autotester to automatically merge the PR branch once approvals are completed label May 3, 2024
@rppawlo rppawlo deleted the nox-reuse-prec-nl-solves branch May 10, 2024 02:01
@cgcgcg
Copy link
Contributor

cgcgcg commented May 31, 2024

@rppawlo I think this should have the "15.2 release note" label, no?

@rppawlo
Copy link
Contributor Author

rppawlo commented May 31, 2024

@cgcgcg - yes. Is there a label for 15.2 yet?

@ccober6
Copy link
Contributor

ccober6 commented Jun 3, 2024

@cgcgcg and @rppawlo, there will not be a 15.2 release, but the 16.0 release will be done probably by the end of June, so use the 16.0 label. @trilinos/framework will make sure include both 15.2 and 16.0 labels for the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etphipp etphipp etphipp approved these changes

Assignees

@rppawlo rppawlo

Labels
16.0 release note AT: PRE-TEST INSPECTED Required to test outside contributions. This label alone will not allow a PR to merge. PA: Nonlinear Solvers Issues that fall under the Trilinos Nonlinear Linear Solvers Product Area pkg: NOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@rppawlo @trilinos-autotester @cgcgcg @ccober6 @etphipp