Kokkos + KokkosKernels Promotion To 4.3.0 (Test) #12863
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…239587
From repository at git@github.com:kokkos/kokkos.git
At commit:
commit 772e745a1a2ab6a0fe3e2f2692561a74cc239587
Merge: 1c60a32b7 0834a1281
Author: Damien L-G <dalg24@gmail.com>
Date: Tue Mar 26 22:11:48 2024 +0900
Merge pull request #6899 from ndellingwood/cherrypick-6892
[4.3.00] Fix a bug in Makefile when using AMD GPU architectures (#6892)
…40572f33ace33e
From repository at git@github.com:kokkos/kokkos-kernels.git
At commit:
commit f909de6f4187a102326acf619140572f33ace33e
Author: Nathan Ellingwood <ndellin@sandia.gov>
Date: Tue Mar 26 12:03:39 2024 -0600
Merge pull request #2147 from lucbv/KK_Utils_cleanup
KokkosKernels Utils: cleaning the zero_vector interface
(cherry picked from commit 363868e4d4c04f48a4eda67a66936bd4d20c30db)
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.20-uvm
Jenkins Parameters
Using Repos:
Pull Request Author: ndellingwood |
lucbv
approved these changes
Mar 26, 2024
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.20-uvm
Jenkins Parameters
|
|
Summary of cdash failures: tldr:
MueLu_CreateOperatorTpetra_MPI_1 sample failure output: Details:Trilinos_PR_gcc-8.3.0
Trilinos_PR_gcc-8.3.0-debug
Trilinos_PR_gcc-8.3.0-serial
Trilinos_PR_clang-11.0.1
Trilinos_PR_intel-2021.3
|
|
Reproduced the MueLu test failures; may test fixes here or in a separate PR with the final snapshots |
ndellingwood
commented
Mar 27, 2024
| // ********************************************************************** | ||
| AxpbyTraits::performChecks(a, X, b, Y); | ||
| #ifdef HAVE_KOKKOSKERNELS_DEBUG | ||
| AxpbyTraits::printInformation(std::cout, "axpby(), unif information"); |
There was a problem hiding this comment.
This line is triggering the MueLu test failures in the host builds; commenting it out allowed tests to pass MueLu_ParameterListInterpreterTpetra and MueLu_CreateOperatorTpetra to pass in the gcc/8.3.0 serial debug build
|
MueLu failures resolved for me with kokkos/kokkos-kernels#2157 Will likely close this PR without additional testing and replace with a new PR containing the finalized 4.3 snapshots In addition, I'd like to preemptively add the RUN_SERIAL marking for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/kokkos @trilinos/kokkos-kernels
Motivation
Test PR
Stakeholder Feedback
Testing