Intrepid2 add H(vol) hierarchical pyramids #12136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved pyramid coordinate methods into Intrepid2_PyramidCoords.hpp.
Offline, also tested H(vol) pyramid values against ESEAS for p=10. This passed as well.
…ded missing test cases for tetrahedron.
…r IntegratedLegendreBasis_HGRAD_PYR.
…v) are implemented, but commented out until we have the bases implemented.)
mperego
approved these changes
Aug 16, 2023
|
Status Flag 'Pre-Test Inspection' - Auto Inspected - Inspection Is Not Necessary for this Pull Request. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: CamelliaDPG |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
The Intel test failure looks like the compiler crashed. Hoping that it's just a transient issue; trying a retest. |
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: CamelliaDPG |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs 30 Mins. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
The Intel test passed this time, but a CUDA test failed. Trying again. |
|
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
|
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
Using Repos:
Pull Request Author: CamelliaDPG |
|
Status Flag 'Pull Request AutoTester' - Jenkins Testing: all Jobs PASSED Pull Request Auto Testing has PASSED (click to expand)Build InformationTest Name: Trilinos_PR_gcc-8.3.0
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-serial
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_gcc-8.3.0-debug
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_clang-11.0.1
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_python3
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_cuda-11.4.2-uvm-off
Jenkins Parameters
Build InformationTest Name: Trilinos_PR_intel-2021.3
Jenkins Parameters
|
|
Status Flag 'Pre-Merge Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED AND APPROVED by [ mperego ]! |
|
Status Flag 'Pull Request AutoTester' - AutoMerge IS ENABLED, but the Label AT: AUTOMERGE is not set. Either set Label AT: AUTOMERGE or manually merge the PR... |
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 18, 2023
…s:develop' (cddbf30). * trilinos-develop: Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 19, 2023
…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 20, 2023
…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 21, 2023
…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 21, 2023
…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...
jmgate
pushed a commit
to tcad-charon/Trilinos
that referenced
this pull request
Aug 21, 2023
…s:develop' (cddbf30). * trilinos-develop: (39 commits) KokkosSparse_spmv_bsrmatrix_impl.hpp: const scalars are still scalars Stokhos: Remove random access memory trait in PCE spmv specializations Stokhos: make view array assignment with random-access LHS work Disallow non-scalar types in KokkosKernels BsrMatrix SpMV Tpetra_BlockCrsMatrix_def.hpp: Use KokkosSparse::spmv MueLu: Removing H2D/D2H transfers in CoordinatesTransferFactory (at least for scalar pdes) ifpack2: fix ambiguous MDF unit test (trilinos#12078) Intrepid2: add H(vol) hierarchical pyramids (trilinos#12136) MueLu: Minor cleanups to Kokkos UncoupledAggregation MueLu: Minor cleanups to Kokkos UncoupledAggregation Tpetra: Upgrades to DeepCopyTimer tool added some new comments about lowCommMakeColMap serial vs device Tpetra: Minor fixes to GDSWstyle test Tpetra: Fixing deprecated code path added range policy to parallel loops Reverted execution space changes on views removing extraneous files from lowCommunicationMakeColMap PR changed execution space for Kokkos views, added selection for serial vs CUDA on lowCommMakeColMap explicitly specified the execution space of the ColIndices device view moved colind_LID device to host for case when NumRemoteColGIDs=0 ...
cwpearson
pushed a commit
to cwpearson/Trilinos
that referenced
this pull request
Sep 19, 2023
## Motivation This PR adds an arbitrary-order, hierarchical basis for H(vol) on the pyramid. This follows trilinos#12079, which added hierarchical bases for H(grad) on the pyramid. Additionally, this PR adds "sub-basis inclusion" tests for both H(vol) and H(grad) on the pyramid, and orientation tests against H(grad) on the pyramid. ## Testing This PR includes "sub-basis inclusion" tests for both H(vol) and H(grad) on the pyramid, and orientation tests against H(grad) on the pyramid. It also adds a simple basis cardinality test for the new H(vol) basis. Additionally, I have done offline comparison with the ESEAS implementation of this basis, testing up to 10th order, with excellent agreement. I hope to include these tests with Intrepid2 soon; this has been prevented previously by the license for ESEAS, but they are changing the license to one that will allow inclusion.
CamelliaDPG
added a commit
that referenced
this pull request
Sep 22, 2023
@trilinos/intrepid2 ## Motivation This PR adds an arbitrary-order, hierarchical basis for H(div) on the pyramid. This follows #12079, which added hierarchical bases for H(grad) on the pyramid, and #12136, which added bases for H(vol). This PR also adds support in CellGeometry for a pyramidal subdivision of regular hexahedral meshes, and support for a rudimentary node numbering within CellGeometry. This is in support of new projection convergence tests, so far implemented for H(grad) and H(vol). H(div) support for such projections actually requires H(curl) bases to be implemented as well; those will be coming in a subsequent PR. Additionally, this PR adds orientation tests against H(div) on the pyramid. ## Testing This PR has orientation and basis cardinality tests for the new H(div) basis. The new CellGeometry features have some limited tests against them as well. It also adds projection convergence tests for H(grad) and H(vol) on the pyramid. Additionally, I have done offline comparison with the ESEAS implementation of this basis, testing up to 9th order, with excellent agreement. (There were actually a couple of bugs I found in ESEAS's implementation, which I plan to submit fixes for there shortly.) I hope to include these tests with Intrepid2 soon; this has been prevented previously by the license for ESEAS, but they are changing the license to one that will allow inclusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trilinos/intrepid2
Motivation
This PR adds an arbitrary-order, hierarchical basis for H(vol) on the pyramid. This follows #12079, which added hierarchical bases for H(grad) on the pyramid.
Additionally, this PR adds "sub-basis inclusion" tests for both H(vol) and H(grad) on the pyramid, and orientation tests against H(grad) on the pyramid.
Testing
This PR includes "sub-basis inclusion" tests for both H(vol) and H(grad) on the pyramid, and orientation tests against H(grad) on the pyramid. It also adds a simple basis cardinality test for the new H(vol) basis.
Additionally, I have done offline comparison with the ESEAS implementation of this basis, testing up to 10th order, with excellent agreement. I hope to include these tests with Intrepid2 soon; this has been prevented previously by the license for ESEAS, but they are changing the license to one that will allow inclusion.