Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tpetra: Help users who want different "global key" types #1959

Closed
mhoemmen opened this issue Nov 6, 2017 · 2 comments
Closed

Tpetra: Help users who want different "global key" types #1959

mhoemmen opened this issue Nov 6, 2017 · 2 comments
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Tpetra TpetraRF

Comments

@mhoemmen
Copy link
Contributor

mhoemmen commented Nov 6, 2017

@trilinos/tpetra

See discussion here: https://github.com/gahansen/Albany/issues/214

The immediate issue is that DTK uses unsigned integers for global indices, while Tpetra prefers signed integers for its GlobalOrdinal template parameter. Furthermore, Tpetra developers would prefer to define the global index type as a single typedef, rather than letting users pick it via template parameter.

If users want a Zoltan-style "global key" type that differs from Tpetra's global index type, my view is that this should be an abstraction above Tpetra's global index type. That would solve DTK's issue as well as more general issues.

@kddevin I have added this to the TpetraRF FY18 project, because it relates to a design choice that Tpetra developers will need to make in FY18.
@mhoemmen mhoemmen mentioned this issue Nov 6, 2017
Closed
@github-actions
Copy link

github-actions bot commented May 1, 2021

This issue has had no activity for 365 days and is marked for closure. It will be closed after an additional 30 days of inactivity.
If you would like to keep this issue open please add a comment and/or remove the MARKED_FOR_CLOSURE label.
If this issue should be kept open even with no activity beyond the time limits you can add the label DO_NOT_AUTOCLOSE.
If it is ok for this issue to be closed, feel free to go ahead and close it. Please do not add any comments or change any labels or otherwise touch this issue unless your intention is to reset the inactivity counter for an additional year.

@github-actions github-actions bot added the MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. label May 1, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

This issue was closed due to inactivity for 395 days.

@github-actions github-actions bot added the CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. label Jun 2, 2021
@github-actions github-actions bot closed this as completed Jun 2, 2021
brian-kelley added a commit to brian-kelley/Trilinos that referenced this issue Sep 6, 2023
@brian-kelley
Stokhos: fix KokkosKernels trilinos#1959
eab6d5d 
PR trilinos#12190 actually failed to fix KokkosSparse::spmv for Sacado scalar
types, when building with Kokkos/KokkosKernels develop branch.

This actually fixes that issue (tested with develop and master KokkosKernels)
and is quite a bit cleaner (though it uses version macros that can be
taken out for the 4.2 release).
trilinos-autotester added a commit that referenced this issue Sep 6, 2023
@trilinos-autotester
Merge Pull Request #12207 from brian-kelley/Trilinos/FixKK1959
5382f31 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Stokhos: fix KokkosKernels #1959'
PR Author: brian-kelley
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Sep 6, 2023
@prwolfe
Merge 'trilinos/Trilinos:develop' (5382f31) into 'tcad-charon/Trilino…
2d7fd8d 
…s:develop' (8ca5e24).

* trilinos-develop:
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Revert "Update per PR review"
  Update per PR review
  Fix typo
  Update documentation/remove unecessary comments
  Update path name
  Update comments
  Update to cmake/SimpleTesting
  Update CUDA builds to remove Epetra stack
  WIP:update pr-ctest-framework to SimpleTesting
  Add SimpleTesting directory
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Sep 6, 2023
@prwolfe
Merge 'trilinos/Trilinos:develop' (5382f31) into 'tcad-charon/Trilino…
f2d4ebe 
…s:develop' (8ca5e24).

* trilinos-develop:
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Revert "Update per PR review"
  Update per PR review
  Fix typo
  Update documentation/remove unecessary comments
  Update path name
  Update comments
  Update to cmake/SimpleTesting
  Update CUDA builds to remove Epetra stack
  WIP:update pr-ctest-framework to SimpleTesting
  Add SimpleTesting directory
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Sep 6, 2023
Merge 'trilinos/Trilinos:develop' (5382f31) into 'tcad-charon/Trilino…
50d3fff 
…s:develop' (8ca5e24).

* trilinos-develop:
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Revert "Update per PR review"
  Update per PR review
  Fix typo
  Update documentation/remove unecessary comments
  Update path name
  Update comments
  Update to cmake/SimpleTesting
  Update CUDA builds to remove Epetra stack
  WIP:update pr-ctest-framework to SimpleTesting
  Add SimpleTesting directory
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Sep 6, 2023
Merge 'trilinos/Trilinos:develop' (5382f31) into 'tcad-charon/Trilino…
96d738b 
…s:develop' (8ca5e24).

* trilinos-develop:
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Revert "Update per PR review"
  Update per PR review
  Fix typo
  Update documentation/remove unecessary comments
  Update path name
  Update comments
  Update to cmake/SimpleTesting
  Update CUDA builds to remove Epetra stack
  WIP:update pr-ctest-framework to SimpleTesting
  Add SimpleTesting directory
jmgate pushed a commit to tcad-charon/Trilinos that referenced this issue Sep 6, 2023
Merge 'trilinos/Trilinos:develop' (5382f31) into 'tcad-charon/Trilino…
8144c34 
…s:develop' (8ca5e24).

* trilinos-develop:
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Revert "Update per PR review"
  Update per PR review
  Fix typo
  Update documentation/remove unecessary comments
  Update path name
  Update comments
  Update to cmake/SimpleTesting
  Update CUDA builds to remove Epetra stack
  WIP:update pr-ctest-framework to SimpleTesting
  Add SimpleTesting directory
jgfouca added a commit to jgfouca/Trilinos that referenced this issue Sep 7, 2023
@jgfouca
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
9dfa45f 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
sebrowne pushed a commit to sebrowne/Trilinos that referenced this issue Sep 11, 2023
@trilinos-autotester @sebrowne
Merge Pull Request trilinos#12207 from brian-kelley/Trilinos/FixKK1959
75b093f 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Stokhos: fix KokkosKernels trilinos#1959'
PR Author: brian-kelley
sebrowne pushed a commit to sebrowne/Trilinos that referenced this issue Sep 11, 2023
@jgfouca @sebrowne
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
81ccf43 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
sebrowne pushed a commit to sebrowne/Trilinos that referenced this issue Sep 11, 2023
@trilinos-autotester
Merge Pull Request trilinos#12207 from brian-kelley/Trilinos/FixKK1959
b4df435 
Automatically Merged using Trilinos Pull Request AutoTester
PR Title: b'Stokhos: fix KokkosKernels trilinos#1959'
PR Author: brian-kelley
sebrowne pushed a commit to sebrowne/Trilinos that referenced this issue Sep 11, 2023
@jgfouca
Merge remote-tracking branch 'origin/develop' into jgfouca/measure_fa…
384e0d6 
…stilu

* origin/develop: (179 commits)
  Framework: Update `detect-mpi-comm-world` GitHub action (trilinos#12199)
  Ifpack2: fix dashboard failures in MDF unit tests (trilinos#12217)
  teuchos(cleaning): remove old type traits is_same
  Use ternary in conditionals involving is_contiguous.
  Extract diagonal blocks from a CRS matrix into separate CRS matrices
  Tpetra: Update Building.rst
  Zoltan2: fix shadow warning
  Stokhos: fix KokkosKernels trilinos#1959
  NOX: fix font in screen output
  Tpetra: fix TAFC changes for UVM enabled
  Tpetra: remove unnecessary exception test
  MueLu: remove deep_copy timers
  Tpetra: fix unit tests, eliminate more deep copies
  Tpetra: remove obsolete TAFC method
  Tpetra: merge two TAFC methods
  MueLu: update lumped diagonal code
  Tpetra: replace device type of resulting view
  Belos: Remove use of hardcoded MPI_COMM_WORLD
  Stokhos: update for new KokkosSparse::spmv overloads
  Tpetra: Removing the incorrect ETI_DEVICES
  ...
csiefer2 pushed a commit that referenced this issue Sep 12, 2023
@brian-kelley @csiefer2
Stokhos: fix KokkosKernels #1959
395f3e9 
PR #12190 actually failed to fix KokkosSparse::spmv for Sacado scalar
types, when building with Kokkos/KokkosKernels develop branch.

This actually fixes that issue (tested with develop and master KokkosKernels)
and is quite a bit cleaner (though it uses version macros that can be
taken out for the 4.2 release).
cwpearson pushed a commit to cwpearson/Trilinos that referenced this issue Sep 19, 2023
@brian-kelley @cwpearson
Stokhos: fix KokkosKernels trilinos#1959
4a75509 
PR trilinos#12190 actually failed to fix KokkosSparse::spmv for Sacado scalar
types, when building with Kokkos/KokkosKernels develop branch.

This actually fixes that issue (tested with develop and master KokkosKernels)
and is quite a bit cleaner (though it uses version macros that can be
taken out for the 4.2 release).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CLOSED_DUE_TO_INACTIVITY Issue or PR has been closed by the GitHub Actions bot due to inactivity. MARKED_FOR_CLOSURE Issue or PR is marked for auto-closure by the GitHub Actions bot. pkg: Tpetra TpetraRF
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mhoemmen