Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge v3.x into master #195

Merged
merged 11 commits into from
Apr 10, 2020
Merged

Merge v3.x into master #195

merged 11 commits into from
Apr 10, 2020

Conversation

HypeMC
Copy link
Contributor

@HypeMC HypeMC commented Apr 10, 2020

No description provided.

dkreuer and others added 11 commits March 9, 2020 23:58
The function may return null values but the return type annotation restricts to return strings only. This workaround prevents PHP from crashing by returning an empty string instead - which is fine because the result is sent to output.
Fix returning possible null values
Add support for registering custom grant types
@codecov-io
Copy link

codecov-io commented Apr 10, 2020

Codecov Report

Merging #195 into master will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #195      +/-   ##
============================================
- Coverage     92.05%   91.96%   -0.10%     
- Complexity      381      387       +6     
============================================
  Files            56       59       +3     
  Lines          1272     1344      +72     
============================================
+ Hits           1171     1236      +65     
- Misses          101      108       +7     
Impacted Files Coverage Δ Complexity Δ
Model/Grant.php 100.00% <ø> (+16.66%) 2.00 <0.00> (-1.00) ⬆️
Command/ListClientsCommand.php 96.72% <100.00%> (ø) 7.00 <0.00> (ø)
DependencyInjection/TrikoderOAuth2Extension.php 91.86% <100.00%> (+0.27%) 27.00 <0.00> (ø)
League/AuthorizationServer/GrantConfigurator.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
.../CredentialsRevoker/DoctrineCredentialsRevoker.php 100.00% <100.00%> (ø) 3.00 <3.00> (?)
OAuth2Grants.php 0.00% <0.00%> (-100.00%) 1.00% <0.00%> (ø%)
.../Exception/OAuth2AuthenticationFailedException.php 100.00% <0.00%> (ø) 1.00% <0.00%> (?%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d65806...7eeb932. Read the comment docs.

@HypeMC HypeMC merged commit 5831863 into master Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants