This repository was archived by the owner on Dec 11, 2023. It is now read-only.
CE Source removed from routing #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a9ead9f to
c37bd71
Compare
fe8ccf3 to
4b4b6bd
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After quite a bit of testing, it looks like exposing more technical details about CloudEvents is not helping on the UX side. Therefore, this PR brings back single-attribute routing based on the EventType.
Having "event source" as the component and "event source" as the CE attribute is highly confusing. Also, automatically operating with two attributes in the CLI instead of one increases its complexity without any significant benefits for users. Methods to work with the CE Source are still there if we decide to get back to it in the future.