Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzer: make sure the buffer is large enough to store the input #286

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

folkertdev
Copy link
Collaborator

fuzzers are broken on today's nightly, hopefully that will be fixed soon.

But I ran into this problem on a local run, and it's a simple fix. I'll wait with merging till we can actually run these on CI though.

@folkertdev folkertdev requested a review from bjorn3 January 15, 2025 22:23
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

see 1 file with indirect coverage changes

Copy link
Collaborator

@bjorn3 bjorn3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be useful to also have a fuzz case for when the output buffer is too small. That this gives exactly the same amount of data as fits in the output buffer and that you can continue getting data if you call into the decompression function again.

@folkertdev
Copy link
Collaborator Author

right, we test this a bunch, but not using fuzzers right now

@folkertdev folkertdev merged commit c753e84 into main Jan 16, 2025
20 checks passed
@folkertdev folkertdev deleted the fuzzer-increase-buffer branch January 16, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants