Remove the padding from the State structure #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cleanup following the recent restructuring of fields for cache locality.
|
On my test system, the performance of this patch is the same as main for compression levels 1-9. |
folkertdev
approved these changes
Jan 9, 2025
Comment on lines
-1229
to
+1219
| #[repr(C)] | ||
| #[repr(C, align(64))] |
There was a problem hiding this comment.
it's fine to have this, because that is the intention, but the state is always stored on the heap, and we make sure that all allocations are aligned to 64 bytes anyway, so in practice this does not have any effect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup following the recent restructuring of fields.