Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zlib-ng version 2.2.3 #282

Merged
merged 4 commits into from
Jan 9, 2025
Merged

Update zlib-ng version 2.2.3 #282

merged 4 commits into from
Jan 9, 2025

Conversation

folkertdev
Copy link
Collaborator

I bumped the zlib-ng version used by libz-sys: turns out it was using a rather dated version in most cases...

Anyway, that changed some things in the algorithms, and so we need to mirror those changes for our tests to pass.

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
test-libz-rs-sys/src/deflate.rs 98.30% <100.00%> (+0.13%) ⬆️
zlib-rs/src/deflate.rs 96.91% <100.00%> (+0.11%) ⬆️
zlib-rs/src/deflate/algorithm/medium.rs 91.81% <100.00%> (-2.20%) ⬇️
zlib-rs/src/deflate/hash_calc.rs 99.04% <ø> (+18.33%) ⬆️
zlib-rs/src/deflate/longest_match.rs 96.18% <100.00%> (+3.50%) ⬆️

... and 3 files with indirect coverage changes

as noted in https://github.com/zlib-ng/zlib-ng/releases/tag/2.2.3, the `UNALIGNED_OK` checks have been removed. That is OK for us, because we read values as `[u8; N]` and hence alignment is not a problem for those loads
@folkertdev folkertdev requested a review from bjorn3 January 9, 2025 13:07
@folkertdev folkertdev merged commit 3ff9e2b into main Jan 9, 2025
20 checks passed
@folkertdev folkertdev deleted the update-zlib-ng-2.2.3 branch January 9, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants