Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run deflate tests under stacked borrows #239

Merged
merged 13 commits into from
Oct 30, 2024

Conversation

folkertdev
Copy link
Collaborator

we now pass the zlib-rs and test-libz-rs-sys tests under miri with (the default) stacked borrows 🎉

cc @inahga

Copy link

codecov bot commented Oct 27, 2024

Codecov Report

Attention: Patch coverage is 93.29268% with 11 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
zlib-rs/src/deflate/hash_calc.rs 66.66% 6 Missing ⚠️
zlib-rs/src/deflate.rs 94.73% 2 Missing ⚠️
zlib-rs/src/allocate.rs 97.36% 1 Missing ⚠️
zlib-rs/src/deflate/window.rs 91.66% 1 Missing ⚠️
zlib-rs/src/weak_slice.rs 94.73% 1 Missing ⚠️
Files with missing lines Coverage Δ
test-libz-rs-sys/src/deflate.rs 98.16% <100.00%> (+<0.01%) ⬆️
test-libz-rs-sys/src/end_to_end.rs 75.71% <ø> (ø)
zlib-rs/src/deflate/longest_match.rs 88.97% <100.00%> (ø)
zlib-rs/src/deflate/pending.rs 96.96% <100.00%> (+0.24%) ⬆️
zlib-rs/src/deflate/slide_hash.rs 99.09% <100.00%> (ø)
zlib-rs/src/inflate/window.rs 97.57% <100.00%> (ø)
zlib-rs/src/read_buf.rs 91.30% <100.00%> (+0.82%) ⬆️
zlib-rs/src/allocate.rs 98.43% <97.36%> (-0.56%) ⬇️
zlib-rs/src/deflate/window.rs 90.19% <91.66%> (+0.61%) ⬆️
zlib-rs/src/weak_slice.rs 96.22% <94.73%> (-0.84%) ⬇️
... and 2 more

... and 3 files with indirect coverage changes

Copy link
Contributor

@inahga inahga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for working through this.

zlib-rs/src/weak_slice.rs Show resolved Hide resolved
@folkertdev folkertdev force-pushed the miri-stacked-borrows-improvements-deflate branch from 63cabff to 6456027 Compare October 30, 2024 09:07
@folkertdev folkertdev merged commit 1f3e042 into main Oct 30, 2024
18 checks passed
@folkertdev folkertdev deleted the miri-stacked-borrows-improvements-deflate branch October 30, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants