Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gzip: make header functions unsafe and document preconditions #235

Merged
merged 1 commit into from
Oct 24, 2024
Merged

gzip: make header functions unsafe and document preconditions #235

merged 1 commit into from
Oct 24, 2024

Conversation

inahga
Copy link
Contributor

@inahga inahga commented Oct 23, 2024

Closes #210.

@inahga inahga marked this pull request as ready for review October 23, 2024 19:14
@inahga
Copy link
Contributor Author

inahga commented Oct 23, 2024

Note this is a breaking API change, since a few public functions are now unsafe.

folkertdev
folkertdev approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@folkertdev folkertdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent, thank you!

@folkertdev folkertdev merged commit e0b0001 into trifectatechfoundation:main Oct 24, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@folkertdev folkertdev folkertdev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deflate::set_header() is unsound
2 participants
@inahga @folkertdev