fix(suite): TradingFormOffer small polishing #17630

jvaclavik · 2025-03-13T08:42:08Z

Description

update alignment
footer is not ugly as before
delete unused component

don't forget:

Related Issue

Resolve

Screenshots:

before

after

coderabbitai · 2025-03-13T08:44:28Z

Walkthrough

The changes update several trading-related components by modifying their layout and styling. The TradingFooter component has been streamlined through the removal of an extra wrapper component and an adjustment of margin spacing, with additional typography rules applied to link elements. The TradingProvidedByInvity component was restructured to use a Text component and a Row layout for alignment instead of the previously used styled wrapper. The TradingFormOffer component received layout adjustments by incorporating a new wrapping div and setting specific column properties for improved content alignment. Additionally, the TradingFormInputLoader component, which rendered a loading spinner, was removed entirely. No modifications were made to the exported or public entities of these components.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b6f2c5f and b06319e.

📒 Files selected for processing (4)

packages/suite/src/views/wallet/trading/common/TradingFooter/TradingFooter.tsx (3 hunks)
packages/suite/src/views/wallet/trading/common/TradingFooter/TradingProvidedByInvity.tsx (1 hunks)
packages/suite/src/views/wallet/trading/common/TradingForm/TradingFormInput/TradingFormInputLoader.tsx (0 hunks)
packages/suite/src/views/wallet/trading/common/TradingForm/TradingFormOffer.tsx (1 hunks)

💤 Files with no reviewable changes (1)

packages/suite/src/views/wallet/trading/common/TradingForm/TradingFormInput/TradingFormInputLoader.tsx

⏰ Context from checks skipped due to timeout of 90000ms (9)

GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
GitHub Check: run-e2e-suite-desktop-tests (@group=other, trezor-user-env-unix)
GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
GitHub Check: run-e2e-suite-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
GitHub Check: run-e2e-suite-desktop-tests (@group=suite, trezor-user-env-unix)
GitHub Check: Setup and Cache Dependencies
GitHub Check: build-web
GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (7)

packages/suite/src/views/wallet/trading/common/TradingFooter/TradingProvidedByInvity.tsx (2)

1-2: Dependencies updated to support new component structure.

The imports have been updated to include necessary components (Text, Row) and styling constants (spacings) to support the new implementation structure.

9-18: Improved component structure using design system primitives.

The component has been refactored from a custom styled wrapper to use the design system's Text and Row components. This change:

Improves consistency with the design system

Makes typography styling more declarative with the typographyStyle and variant props

Provides better layout control with the Row component's alignment and spacing

The refactoring maintains the same functionality while improving code quality.

packages/suite/src/views/wallet/trading/common/TradingForm/TradingFormOffer.tsx (2)

85-85: Enhanced layout structure with proper vertical spacing.

Added justifyContent="space-between" and height="100%" to ensure content is properly distributed within the container. This improves the visual hierarchy and spacing of the component.

86-153: Improved content organization with wrapper element.

The addition of a wrapper <div> creates a clearer separation between the main content and the action button at the bottom. This structural change works together with the justifyContent="space-between" to create a more balanced layout.

packages/suite/src/views/wallet/trading/common/TradingFooter/TradingFooter.tsx (3)

15-15: Adjusted top margin for better vertical spacing.

The margin-top has been reduced from xxxl to xl spacing, creating a more balanced vertical rhythm with surrounding elements.

75-75: Applied consistent typography style to links.

Added ${typography.hint} to the link styling to ensure consistent text appearance across the application. This improves the visual consistency of the component.

118-157: Simplified component structure by removing unnecessary wrapper.

The nested structure has been simplified by removing the WrapperBorder component and directly placing the Row component inside the Wrapper. This change:

Reduces DOM nesting

Maintains the same visual output and functionality

Makes the code more maintainable

This is a good example of component cleanup without changing the user experience.

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

vojtatranta

Looks good (I mean like the UI)

vojtatranta · 2025-03-13T08:59:46Z

packages/suite/src/views/wallet/trading/common/TradingForm/TradingFormOffer.tsx

+            <div>
+                <Column gap={spacings.xs} data-testid="@trading/best-offer">
+                    <Translation id={amountLabels.offerLabel} />
+                    {shouldDisplayFiatAmount ? (


Yeah, I think <If><Else> would be readable, I'll add it.

adderpositive

CTA button should not be on the end of the box.

adderpositive · 2025-03-13T09:07:55Z

packages/suite/src/views/wallet/trading/common/TradingFooter/TradingFooter.tsx

-const WrapperBorder = styled.div`
-    padding-top: ${spacingsPx.lg};
-    border-top: 1px solid ${({ theme }) => theme.borderElevation1};
+    margin-top: ${spacingsPx.xl};


Could the Row component replace this custom style?

Or in this PR be replaced with other custom styles? Will you have some time for that? 🫣🙏

seibei-iguchi · 2025-03-13T09:40:48Z

packages/suite/src/views/wallet/trading/common/TradingFooter/TradingFooter.tsx

-const WrapperBorder = styled.div`
-    padding-top: ${spacingsPx.lg};
-    border-top: 1px solid ${({ theme }) => theme.borderElevation1};
+    margin-top: ${spacingsPx.xl};


Margin top shouldn't be in this context, imo, but in the parent component where the layout composition occurs, via column or something like that.

fix(suite): TradingFormOffer small polishing

b06319e

jvaclavik requested review from adderpositive, seibei-iguchi and vojtatranta March 13, 2025 08:42

jvaclavik self-assigned this Mar 13, 2025

vojtatranta approved these changes Mar 13, 2025

View reviewed changes

vojtatranta reviewed Mar 13, 2025

View reviewed changes

adderpositive requested changes Mar 13, 2025

View reviewed changes

seibei-iguchi reviewed Mar 13, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(suite): TradingFormOffer small polishing #17630

fix(suite): TradingFormOffer small polishing #17630

jvaclavik commented Mar 13, 2025 •

edited

Loading

coderabbitai bot commented Mar 13, 2025

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

vojtatranta left a comment

vojtatranta Mar 13, 2025

adderpositive left a comment

adderpositive Mar 13, 2025

adderpositive Mar 13, 2025

seibei-iguchi Mar 13, 2025

fix(suite): TradingFormOffer small polishing #17630

Are you sure you want to change the base?

fix(suite): TradingFormOffer small polishing #17630

Conversation

jvaclavik commented Mar 13, 2025 • edited Loading

Description

Related Issue

Screenshots:

coderabbitai bot commented Mar 13, 2025

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

vojtatranta left a comment

Choose a reason for hiding this comment

vojtatranta Mar 13, 2025

Choose a reason for hiding this comment

adderpositive left a comment

Choose a reason for hiding this comment

adderpositive Mar 13, 2025

Choose a reason for hiding this comment

adderpositive Mar 13, 2025

Choose a reason for hiding this comment

seibei-iguchi Mar 13, 2025

Choose a reason for hiding this comment

jvaclavik commented Mar 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)