fix(ds): Color design tokens are clickable in IDE + fix typos #17625

jvaclavik · 2025-03-13T06:53:50Z

Description

only for DX

Related Issue

Resolve

Screenshots:

coderabbitai · 2025-03-13T06:56:02Z

Walkthrough

This pull request updates the type declarations for theme palette constants in the theme package. The explicit type annotations using Record<string, CSSColor> have been removed from both paletteV1 and paletteV2 declarations. Instead, the constants are now defined with a type assertion using as const satisfies Record<string, CSSColor>. This change leverages TypeScript’s type inference capabilities while ensuring that the objects conform to the required structure and remain immutable. Additionally, a casing correction has been made in the colorsV2 object, changing globaltransparent to globalTransparent in both the light and dark themes. Furthermore, a similar casing correction was applied in the colors.ts file, changing LightBlackAlpha600 to lightBlackAlpha600. The overall structure and content of the objects remain the same.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 73453b5 and 5971a9c.

📒 Files selected for processing (4)

packages/theme/src/colors.ts (1 hunks)
packages/theme/src/colorsV2.ts (2 hunks)
packages/theme/src/paletteV1.ts (2 hunks)
packages/theme/src/paletteV2.ts (2 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/theme/src/colors.ts

🚧 Files skipped from review as they are similar to previous changes (3)

packages/theme/src/paletteV2.ts
packages/theme/src/colorsV2.ts
packages/theme/src/paletteV1.ts

⏰ Context from checks skipped due to timeout of 90000ms (3)

GitHub Check: Analyze with CodeQL (javascript)
GitHub Check: build-web
GitHub Check: Setup and Cache Dependencies

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jvaclavik · 2025-03-13T06:57:43Z

packages/theme/src/colorsV2.ts

@@ -116,7 +116,7 @@ export const colorsV2 = {
        baseFillElementBrandSofterInverse: paletteV2.darkGreenAlpha50,
        baseFillElementBrandSoftInverse: paletteV2.darkGreenAlpha75,
        baseFillElementElevated: paletteV2.globalWhiteAlpha1000,
-        baseFillElementGhost: paletteV2.globaltransparent,
+        baseFillElementGhost: paletteV2.globalTransparent,


jvaclavik · 2025-03-13T06:57:52Z

packages/theme/src/colorsV2.ts

@@ -476,7 +476,7 @@ export const colorsV2 = {
        baseFillElementBrandSofterInverse: paletteV2.darkGreenAlpha50,
        baseFillElementBrandSoftInverse: paletteV2.darkGreenAlpha75,
        baseFillElementElevated: paletteV2.darkCoolGrey75,
-        baseFillElementGhost: paletteV2.globaltransparent,
+        baseFillElementGhost: paletteV2.globalTransparent,


jvaclavik · 2025-03-13T07:45:53Z

packages/theme/src/colors.ts

@@ -264,7 +264,7 @@ export const colorVariants: Record<ThemeColorVariant, Colors> = {
        borderOnElevation0: paletteV1.darkGray300,
        borderOnElevation1: paletteV1.darkGray400,
        borderSecondary: paletteV1.darkSecondaryGreen800,
-        borderSubtleInverted: paletteV1.LightBlackAlpha600,
+        borderSubtleInverted: paletteV1.lightBlackAlpha600,


jvaclavik requested review from seibei-iguchi and vojtatranta March 13, 2025 06:53

jvaclavik requested review from Nodonisko and a team as code owners March 13, 2025 06:53

jvaclavik force-pushed the colors-are-clickable-in-ide branch from d68fd8b to 73453b5 Compare March 13, 2025 06:57

jvaclavik commented Mar 13, 2025

View reviewed changes

fix(ds): Color design tokens are clickable in IDE

5971a9c

jvaclavik force-pushed the colors-are-clickable-in-ide branch from 73453b5 to 5971a9c Compare March 13, 2025 07:45

jvaclavik commented Mar 13, 2025

View reviewed changes

jvaclavik self-assigned this Mar 13, 2025

jvaclavik changed the title ~~fix(ds): Color design tokens are clickable in IDE~~ fix(ds): Color design tokens are clickable in IDE + fix typos Mar 13, 2025

vojtatranta approved these changes Mar 13, 2025

View reviewed changes

jvaclavik merged commit 4d1c3be into develop Mar 13, 2025
29 checks passed

jvaclavik deleted the colors-are-clickable-in-ide branch March 13, 2025 09:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(ds): Color design tokens are clickable in IDE + fix typos #17625

fix(ds): Color design tokens are clickable in IDE + fix typos #17625

jvaclavik commented Mar 13, 2025 •

edited

Loading

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

jvaclavik Mar 13, 2025

jvaclavik Mar 13, 2025

jvaclavik Mar 13, 2025 •

edited

Loading

fix(ds): Color design tokens are clickable in IDE + fix typos #17625

fix(ds): Color design tokens are clickable in IDE + fix typos #17625

Conversation

jvaclavik commented Mar 13, 2025 • edited Loading

Description

Related Issue

Screenshots:

coderabbitai bot commented Mar 13, 2025 • edited Loading

Walkthrough

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

jvaclavik Mar 13, 2025

Choose a reason for hiding this comment

jvaclavik Mar 13, 2025

Choose a reason for hiding this comment

jvaclavik Mar 13, 2025 • edited Loading

Choose a reason for hiding this comment

jvaclavik commented Mar 13, 2025 •

edited

Loading

coderabbitai bot commented Mar 13, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

jvaclavik Mar 13, 2025 •

edited

Loading