fix(suite): Fix TransactionGraph tooltip overflow

[jvaclavik]

Description

Related Issue

Resolve

Screenshots:

before

after

[jvaclavik]

looks like there was a duplicity

[jvaclavik]

actually I think it couldn't work before

[coderabbitai]

Walkthrough

The changes update the implementation of the Card components and related styled components. In the Card component file, a new type alias is introduced to wrap allowed frame properties, and its usage is integrated into both the Container and CardContainer components. A new property $overflow is added to the CardContainer’s type and used in its styled definition to conditionally set the CSS overflow behavior, defaulting to "hidden" when not provided. Additionally, the Card component now passes the $overflow prop from its frame properties to the CardContainer. In a separate view related to transaction summaries, the Card component is modified to include an explicit overflow prop set to "visible", thereby altering its rendering behavior.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8ddf478 and 9d758eb.

📒 Files selected for processing (2)

• packages/components/src/components/Card/Card.tsx (3 hunks)
• packages/suite/src/views/wallet/transactions/components/TransactionSummary.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies

🔇 Additional comments (6)

packages/suite/src/views/wallet/transactions/components/TransactionSummary.tsx (1)

117-117: Resolves tooltip overflow by making card content visible

This change addresses the PR's main objective by setting overflow="visible" on the Card component, allowing the TransactionGraph tooltips to extend beyond the card boundaries without being clipped.

packages/components/src/components/Card/Card.tsx (5)

45-45: Good type abstraction for frame properties

Creating this type alias improves code readability and maintainability by centralizing the transient props type definition.

---

47-47: Updated Container component type definition

Properly utilizing the new TransientAllowedFrameProps type alias in the Container styled component.

---

68-68: Added overflow control to CardContainerProps

This addition is necessary to support the overflow customization at the component level.

---

75-75: Implemented conditional overflow CSS property

The implementation correctly uses the provided $overflow prop with a fallback to 'hidden', maintaining backward compatibility while enabling customization.

---

181-181: Connected frame props to CardContainer

This line properly passes the overflow value from the Card's frame properties to the CardContainer, completing the prop flow chain.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.