fix(suite): Heading buttons depends on content width

[jvaclavik]

Description

Related Issue

Resolve

Screenshots:

before

Screen.Recording.2025-03-12.at.19.04.38.mov

after

Screen.Recording.2025-03-12.at.19.30.16.mov

[coderabbitai]

Walkthrough

The changes update the TradeActions component in the SuiteLayout's PageHeader by removing the ShowOnLargeDesktopWrapper styled component and replacing it with conditional rendering based on the contentWidth obtained from the useResponsiveContext hook. The logic now evaluates whether the contentWidth exceeds specific breakpoint thresholds to determine the visibility of the HeaderActionButton for trading actions. Additionally, in the HeaderActionButton component, the layout size determination has shifted from using Redux state to the responsive context, specifically evaluating the contentWidth against defined breakpoint thresholds. This restructuring modifies how trading actions are displayed based on device size and content width, enhancing the component's responsiveness.

Tip

⚡🧪 Multi-step agentic review comment chat (experimental)

• We're introducing multi-step agentic chat in review comments. This experimental feature enhances review discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments.
  - To enable this feature, set early_access to true under in the settings.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/HeaderActionButton.tsx (1)

16-17: Improved responsive logic determination.

The change from Redux state to responsive context for layout decisions is a good approach. The null check for contentWidth with a default to false is appropriate.

However, consider extracting this responsive logic into a custom hook for reusability:

- const { contentWidth } = useResponsiveContext();
- const isContentAreaSmall = contentWidth ? contentWidth < breakpointThresholds.sm : false;
+ const { isContentAreaSmall } = useResponsiveLayout(); // Custom hook that encapsulates this logic

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f75cf0d and a6286b8.

📒 Files selected for processing (2)

• packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/HeaderActionButton.tsx (2 hunks)
• packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/TradeActions.tsx (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/TradeActions.tsx

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: build-web
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (3)

packages/suite/src/components/suite/layouts/SuiteLayout/PageHeader/HeaderActionButton.tsx (3)

2-2: Added import for breakpoint thresholds.

Good addition of the breakpoint constants from the styles package. Using predefined breakpoint thresholds ensures consistency across the application.

---

4-4: Switched to responsive context approach.

Good refactoring to use the useResponsiveContext hook instead of Redux for responsive behavior. This creates a cleaner separation of concerns and likely reduces unnecessary re-renders.

---

20-20: Updated conditional rendering based on content width.

Good implementation of the conditional rendering based on the new responsive context approach. This change aligns with the PR's objective to fix the trade heading display.