Fix failing tests

[HajekOndrej]

Description

Related Issue

Resolve

Screenshots:

[coderabbitai]

Walkthrough

The changes involve three separate modifications. The first update adds the command-line argument --limit 100 to the gh workflow list command in the GitHub Actions workflow file, ensuring that the output is capped at 100 entries. The second update modifies the text in a custom matcher method by replacing the footer string from "Swipe up" to "Tap to continue". The third change removes a line from a wallet account type test, which previously clicked on the normal account menu, thereby altering the flow of the test by skipping this specific user interaction. No changes were made to the exported or public entity declarations in any of the files.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5c0da71 and 578d2d9.

📒 Files selected for processing (3)

• .github/actions/check-previous-test-runs/action.yml (1 hunks)
• packages/suite-desktop-core/e2e/support/testExtends/customMatchers.ts (1 hunks)
• packages/suite-desktop-core/e2e/tests/wallet/add-account-types.test.ts (0 hunks)

💤 Files with no reviewable changes (1)

• packages/suite-desktop-core/e2e/tests/wallet/add-account-types.test.ts

🧰 Additional context used

🧠 Learnings (1)

packages/suite-desktop-core/e2e/support/testExtends/customMatchers.ts (1)

Learnt from: Vere-Grey
PR: trezor/trezor-suite#17500
File: packages/suite-desktop-core/e2e/support/testExtends/customMatchers.ts:49-70
Timestamp: 2025-03-12T13:05:17.357Z
Learning: In the `transformAddress` function used for e2e testing in Trezor Suite, `formatAddress()` is intentionally applied only to the 'fourTetragrams' format (which displays addresses in groups of 4 characters), and not to the 'fullLine' format (which displays addresses in lines of up to 18 characters without tetragram grouping).

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (1)

.github/actions/check-previous-test-runs/action.yml (1)

42-46:

✅ Verification successful

Improvement: Added limit to GitHub workflow list

Adding the --limit 100 parameter to the gh workflow list command is a good optimization that will prevent potential performance issues when retrieving workflow data. This helps control the response size and execution time.

However, be aware that if your repository has more than 100 workflows and the target workflow happens to be beyond this limit, the script might fail to find it.

---

🏁 Script executed:

#!/bin/bash
# Check how many workflows exist in the repository to ensure 100 is sufficient
gh workflow list --repo "$GITHUB_REPOSITORY" | wc -l

Length of output: 39

---

Code Verification: --limit 100 is Safe in Current Context

The recent test confirms there are 50 workflows in the repository, well within the 100 workflow limit. This verifies that the added --limit 100 parameter is an effective optimization without impacting the retrieval of the target workflow.

• The limit prevents unnecessary performance overhead when many workflows exist.
• The current count of 50 workflows ensures that the target workflow is not inadvertently omitted.