fix(suite-native): send max button appears on change

[PeKne]

Description

• The send max button is displayed whenever the address input is valid. It used to be displayed only if the field was marked as isTouched, which made the button appear unexpectedly.

Related Issue

Resolve #17604

Screenshots:

Screen.Recording.2025-03-12.at.4.13.00.PM.mov

[coderabbitai]

Walkthrough

The changes affect two components within the codebase. In the AddressInput.tsx file, the fillSelfAddress function has been updated so that when a fresh account address is set, the input field is no longer marked as "touched" due to the removal of the shouldTouch: true option from the setValue function. In the SendMaxButton.tsx file, the address validation logic has been refined. An import for the isAddressValid function from @suite-common/wallet-utils has been added, and the way the address field value is accessed from the useField hook has been adjusted by replacing the extraction of hasError and isTouched with direct retrieval of the value. The existing address validation is now encapsulated in a variable named isAddressInputValid, which evaluates the address based on its value and symbol. No changes were made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92b5da2 and 57f0ea0.

📒 Files selected for processing (2)

• suite-native/module-send/src/components/AddressInput.tsx (0 hunks)
• suite-native/module-send/src/components/SendMaxButton.tsx (3 hunks)

💤 Files with no reviewable changes (1)

• suite-native/module-send/src/components/AddressInput.tsx

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: prepare_android_test_app
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (4)

suite-native/module-send/src/components/SendMaxButton.tsx (4)

10-10: LGTM: Added needed dependency for address validation

The import of isAddressValid function is appropriate for the implementation of address validation logic.

---

40-42: LGTM: Improved field value extraction

Good change from extracting form field metadata (likely hasError and isTouched based on the summary) to directly accessing the actual addressValue, which better supports the PR objective of showing the max button based on address validity rather than touch state.

---

51-51: LGTM: Clear address validation logic

The new validation approach correctly checks both that the symbol is defined and that the address is valid for that symbol. This implementation directly addresses the PR objective of displaying the max button based on address validity.

---

54-54: LGTM: Updated condition for max button availability

The condition now correctly uses the new isAddressInputValid variable, which ensures the max button appears whenever the address is valid, not just when the field is marked as touched. This directly implements the PR objective.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.