fix(suite): when switching the device, make sure that the correspondi… #17609
+33
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng account exists on the other device wallet
425190e to
ca9541e
Compare
vojtatranta
commented
Mar 12, 2025
| // has a corresponding account in the next device accounts | ||
| // if not, enforce switching URL to dashboard | ||
| const nextAccount = nextDeviceAccounts.find( | ||
| account => |
There was a problem hiding this comment.
is this correct way of finding "correspoding" accout to switch to?
vojtatranta
commented
Mar 12, 2025
| `${DEVICE_MODULE_PREFIX}/redirectAfterWalletSelectedThunk`, | ||
| async (_, { dispatch }) => { | ||
| async ({ forceDeviceDashboard }, { dispatch }) => { |
There was a problem hiding this comment.
This thunk was written by @seibei-iguchi I am not sure what it was suppose to do though.
There was a problem hiding this comment.
Yeah, in some cases, it went to dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng account exists on the other device wallet
Description
When you are in a device / wallet on /btc/4/ account and you switch to a different device / wallet that doesn't have /btc/4 but like just 1 btc account, it ended up in "Accout not found".
In this PR, I first check if that account existss
Related Issue
Resolve #4465
Screenshots: