-
-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(e2e): Canary FW CI pipelines for playwright tests #17606
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe changes introduce two new GitHub Actions workflow files and a minor update to a code file. One workflow file automates the desktop end-to-end (E2E) test suite by loading an E2E test matrix and executing tests on an Ubuntu environment, using scheduled and manual triggers. The second workflow file automates the Suite Web application E2E tests, executing a build step, loading the test matrix, and running tests via Playwright on a scheduled nightly basis as well as on manual invocation. Both workflows incorporate conditions based on the repository name and pass environment variables, including a canary firmware flag and test secrets, to the tests. Additionally, a logging statement has been added to the ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
packages/trezor-user-env-link/src/api.ts (1)
205-205
: Logging Statement Addition: Validate Sensitive Data Exposure
The new logging statement outputs the emulator startup parameters. Please verify that no sensitive information (such as secrets or personal data) is included in these parameters when logged. If this logging is for debugging in a controlled environment, it’s acceptable; otherwise, consider masking any sensitive values..github/workflows/test-suite-web-e2e-fw-canary.yml (1)
1-79
: New Suite Web E2E Workflow: Well-Structured Setup
This new GitHub Actions workflow for running nightly and manually triggered Suite Web e2e tests is clear and well structured. The file correctly specifies triggers, permissions, environment variables, and the three-step job sequence (build, load matrix, run tests). Please ensure that the custom actions (e.g., build-web, load-e2e-matrix, run-e2e-tests) are covered by tests and documented to streamline troubleshooting in CI.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
.github/workflows/test-suite-desktop-e2e-fw-canary.yml
(1 hunks).github/workflows/test-suite-web-e2e-fw-canary.yml
(1 hunks)packages/trezor-user-env-link/src/api.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (12)
- GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-e2e-suite-desktop-tests (@group=other, trezor-user-env-unix)
- GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
- GitHub Check: run-e2e-suite-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
- GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
- GitHub Check: run-e2e-suite-desktop-tests (@group=suite, trezor-user-env-unix)
- GitHub Check: build-deploy
- GitHub Check: build-deploy
- GitHub Check: transport-e2e-test
- GitHub Check: Setup and Cache Dependencies
- GitHub Check: Analyze with CodeQL (javascript)
- GitHub Check: build-web
🔇 Additional comments (1)
.github/workflows/test-suite-desktop-e2e-fw-canary.yml (1)
1-66
: New Suite Desktop E2E Workflow: Clear and Consistent Configuration
This new workflow file for desktop E2E tests is well organized. It correctly defines the scheduling, conditional execution based on the repository, and the multi-step process including checkout, Node.js setup (with reference to the .nvmrc file), desktop app build, and running Playwright tests. Ensure that the Node.js version specified in your .nvmrc aligns with your project requirements and that the caching mechanism for Yarn dependencies is functioning as intended.
Description
Added jobs to test with main firmware.
Related Issue
Resolve
Screenshots: