fix(e2e): stabilize t2t1 backup fail test

[Vere-Grey]

Related Issue

Resolve #17241

Screenshots:

[coderabbitai]

Walkthrough

The changes introduce new locator properties in two page object classes and restructure a test case. In the DashboardPage class, a new property notificationFailedBackup is added to target a failed backup notification element. In the BackupSection class, two new locator properties, noDeviceModal and errorModal, are added to reference modals for device absence and error messages during the onboarding process. Additionally, a previously skipped test for handling device disconnection during backup has been re-enabled and restructured into clear, sequential steps using test.step(). The revised test organizes actions into initiating the backup, simulating a disconnect, handling a reconnect with error checks, and validating the dashboard's error notification. Commented-out code in the test has also been removed to streamline the logic. Furthermore, the addHiddenWallet method's invocation in the passphrase test case has been updated to include a new parameter, skipDiscovery, modifying the wallet addition process.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3cd88b2 and 6878cd3.

📒 Files selected for processing (4)

• packages/suite-desktop-core/e2e/support/pageObjects/dashboardPage.ts (3 hunks)
• packages/suite-desktop-core/e2e/support/pageObjects/onboarding/backupSection.ts (2 hunks)
• packages/suite-desktop-core/e2e/tests/backup/t2t1-fail.test.ts (1 hunks)
• packages/suite-desktop-core/e2e/tests/passphrase/passphrase.test.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• packages/suite-desktop-core/e2e/support/pageObjects/onboarding/backupSection.ts
• packages/suite-desktop-core/e2e/support/pageObjects/dashboardPage.ts
• packages/suite-desktop-core/e2e/tests/backup/t2t1-fail.test.ts

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: run-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: build-web
• GitHub Check: Analyze with CodeQL (javascript)

🔇 Additional comments (1)

packages/suite-desktop-core/e2e/tests/passphrase/passphrase.test.ts (1)

109-109: Good addition of the skipDiscovery option.

Adding the skipDiscovery parameter to the addHiddenWallet method call is a good approach to stabilize the test. This will prevent unnecessary wallet discovery operations that aren't required for testing passphrase functionality, potentially reducing test flakiness.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.