fix(suite-native): welcome flow device disconnected alert

[PeKne]

Description

• fixes an issue when device disconnected alert was displayed after finishing the welcome flow
• this is only a hotfix, proper solution will come up as a followup to make things simple for the upcoming freeze

[coderabbitai]

Walkthrough

The changes update the logic within the exitOnboardingFlow function on the BiometricsScreen component. Previously, the function immediately dispatched the setIsOnboardingFinished action before executing the navigation away from the screen. With this update, a setTimeout is introduced to delay the dispatching of the state update by 500 milliseconds, ensuring that the navigation completes first. This modification is intended to resolve an issue where the onboarding screen might still be active while the Redux state had already been altered, leading to incorrect alerts from the useHandleDeviceConnection hook. No changes were made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7f17c04 and 4fc7f19.

📒 Files selected for processing (1)

• suite-native/module-onboarding/src/screens/BiometricsScreen.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: prepare_android_test_app
• GitHub Check: Setup and Cache Dependencies

🔇 Additional comments (1)

suite-native/module-onboarding/src/screens/BiometricsScreen.tsx (1)

62-69: Effective hotfix, but consider a more robust solution later.

The setTimeout approach successfully addresses the timing issue between navigation and state updates, preventing the incorrect device disconnected alert. The comments clearly explain the problem and solution, which is helpful for future maintenance.

However, using a timeout is somewhat fragile as it:

• Doesn't guarantee navigation will complete in exactly 500ms
• May behave differently across devices with varying performance
• Could be difficult to test reliably

Consider tracking this with a technical debt ticket to implement a more robust solution later, such as:

• Using navigation events to trigger the state update
• Refactoring the useHandleDeviceConnection hook to be aware of the onboarding state
• Implementing a proper navigation middleware

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[matejkriz]

Approved as temporary solution.

[STew790]

QA OK
Device disconnected alert is no longer showing after welcome flow.

Info
25.3.1 f167ab3