Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite-native): set trading environment #17547

Merged
merged 1 commit into from
Mar 12, 2025

Conversation

vytick
Copy link
Contributor

@vytick vytick commented Mar 10, 2025

Add UI picker for environment, save it to trading state and export via extra dependencies to use in loadInitialDataThunk

Related Issue

Resolve #17136

Screenshots:

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-03-10.at.21.17.12.mp4

@vytick vytick added +Invity Related to Invity project mobile Suite Lite issues and PRs labels Mar 10, 2025
@vytick vytick requested review from jbazant and adderpositive March 10, 2025 20:24
@vytick vytick requested a review from a team as a code owner March 10, 2025 20:24
Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

The changes involve the introduction of the TradingEnvironmentSelect component, which utilizes InvityServerEnvironment and invityAPI from @suite-common/trading. A constant, tradingEnvironmentItems, has been created to generate an array of selectable trading environments. The DevUtilsScreen component has been modified to include the new TradingEnvironmentSelect and a Text component for labeling. In the Redux slice, the TradingState interface has been updated to include a tradingEnvironment property of type InvityServerEnvironment, with the initial state set to 'production'. A new reducer, setTradingEnvironment, and a selector, selectTradingEnvironment, have been added to manage and retrieve the trading environment state. The test suite for the trading slice has been updated to include tests for the tradingEnvironment. Additionally, the selectTradingEnvironment selector has been added to the extraDependencies, a new dependency, @suite-common/trading, has been included in package.json, and a new TypeScript declaration file for Redux has been introduced. A reference path has been added to the tsconfig.json for improved module integration.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]

This comment was marked as outdated.

Copy link

github-actions bot commented Mar 10, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@vytick vytick marked this pull request as draft March 11, 2025 06:28
Copy link
Contributor

@jbazant jbazant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Love those tests.

@trezor-ci trezor-ci force-pushed the feat/native/trading-environmentl-picker branch from 65febc8 to 07ed240 Compare March 11, 2025 13:40
@vytick vytick marked this pull request as ready for review March 11, 2025 13:43
coderabbitai[bot]

This comment was marked as outdated.

@trezor-ci trezor-ci force-pushed the feat/native/trading-environmentl-picker branch from 07ed240 to f59ae19 Compare March 11, 2025 15:54
@vytick vytick force-pushed the feat/native/trading-environmentl-picker branch from f59ae19 to 698c389 Compare March 11, 2025 16:16
@adderpositive adderpositive self-requested a review March 11, 2025 16:23
@trezor-ci trezor-ci force-pushed the feat/native/trading-environmentl-picker branch from dcc4bdf to 48c2317 Compare March 11, 2025 20:05
coderabbitai[bot]

This comment was marked as outdated.

coderabbitai[bot]

This comment was marked as off-topic.

@trezor trezor deleted a comment from github-actions bot Mar 11, 2025
@trezor trezor deleted a comment from github-actions bot Mar 11, 2025
@trezor trezor deleted a comment from github-actions bot Mar 11, 2025
@vytick vytick merged commit 5611f24 into develop Mar 12, 2025
71 of 73 checks passed
@vytick vytick deleted the feat/native/trading-environmentl-picker branch March 12, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
+Invity Related to Invity project mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile - Add Invity API picker to Dev utils
3 participants