Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add some exclusion to types to better handle remmaped DeviceEvent type to Redux Actions #17520

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

peter-sanderson
Copy link
Contributor

@peter-sanderson peter-sanderson commented Mar 10, 2025

This is an alternative (compromise) solution to this problem.

Resolves: #16839

@coderabbitai ignore

coderabbitai[bot]

This comment was marked as resolved.

Copy link

github-actions bot commented Mar 10, 2025

🚀 Expo preview is ready!

  • Project → trezor-suite-preview
  • Platforms → android, ios
  • Scheme → trezorsuitelite
  • Runtime Version → 26
  • More info

Learn more about 𝝠 Expo Github Action

@peter-sanderson peter-sanderson force-pushed the fix-types-device-actions branch from 5ab784f to 458e934 Compare March 10, 2025 12:39
@trezor trezor deleted a comment from coderabbitai bot Mar 10, 2025
@peter-sanderson peter-sanderson force-pushed the fix-types-device-actions branch 4 times, most recently from 1bf1da0 to d6bd13f Compare March 11, 2025 09:03
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@peter-sanderson peter-sanderson force-pushed the fix-types-device-actions branch from a5f306a to d5f6bc7 Compare March 12, 2025 08:30
Copy link
Contributor

@Lemonexe Lemonexe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, you didn't have to credit me, you're too nice 😊

@peter-sanderson peter-sanderson force-pushed the fix-types-device-actions branch from d5f6bc7 to e3663f3 Compare March 12, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: TrezorConnectEvents
2 participants