fix(ds): Set default Tooltip cursor to inherit (not help)

[jvaclavik]

Description

Related Issue

Resolve

Screenshots:

[coderabbitai]

Walkthrough

The update modifies the default cursor style applied to the Content component within the Tooltip component. The cursor style previously set to 'help' when no cursor was provided in frameProps has been changed to default to 'inherit'. This adjustment allows the tooltip to inherit the cursor style from its parent element instead of enforcing a specific cursor style. Additionally, the test cases for the Tooltip component have been updated to reflect this change, altering the expected cursor style from 'help' to 'inherit' when the cursor prop is not provided. Furthermore, the commit hash for the subproject submodules/trezor-common has been updated from e8792ecc2659d756798f38c85482238c8a9da942 to 648fff95111282683f25f9beed6308c8b3f712d4. No alterations were made to the declarations of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 32d4603 and 4d1e651.

📒 Files selected for processing (3)

• packages/components/src/components/Tooltip/Tooltip.test.tsx (1 hunks)
• packages/components/src/components/Tooltip/Tooltip.tsx (1 hunks)
• submodules/trezor-common (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

• submodules/trezor-common
• packages/components/src/components/Tooltip/Tooltip.test.tsx
• packages/components/src/components/Tooltip/Tooltip.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: build-web
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: Setup and Cache Dependencies

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vojtatranta]

hit it!

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/components/src/components/Tooltip/Tooltip.test.tsx (1)

99-107: LGTM! The updated test correctly reflects the new default cursor behavior.

The change from 'help' to 'inherit' for the default cursor style is a good improvement as it allows the tooltip to respect the parent element's cursor style rather than enforcing a specific cursor. This provides more flexibility for component consumers.

Note: There's a minor typo in the test description - "should should" (duplicated word).

-    it('should should apply the default=inherit cursor when the passed cursor is undefined', () => {
+    it('should apply the default=inherit cursor when the passed cursor is undefined', () => {

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between adc74b2 and 32d4603.

📒 Files selected for processing (3)

• packages/components/src/components/Tooltip/Tooltip.test.tsx (1 hunks)
• packages/components/src/components/Tooltip/Tooltip.tsx (1 hunks)
• submodules/trezor-common (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• submodules/trezor-common

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/components/src/components/Tooltip/Tooltip.tsx

⏰ Context from checks skipped due to timeout of 90000ms (9)

• GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=other, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=settings, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=device-management, trezor-user-env-unix)
• GitHub Check: run-e2e-suite-desktop-tests (@group=suite, trezor-user-env-unix)
• GitHub Check: Setup and Cache Dependencies
• GitHub Check: build-web
• GitHub Check: Analyze with CodeQL (javascript)