fix(suite): Fix wallet instance label click

[jvaclavik]

Description

broke here: bda230c

Related Issue

Resolve #17402

Screenshots:

[vojtatranta]

I just looked at this PR that introduced this stopPropagation. #16882 I would compare the original goal of the fix with the current state. Because this looks weird. Maybe there is a way to delete both.

But up to you

[jvaclavik]

There was an issue with coin control. Now it should be also fixed.

[vojtatranta]

looks fixed

[coderabbitai]

Walkthrough

The pull request updates the event handling logic in the MetadataLabeling component. The onClick event handler for the LabelContainer has been modified to conditionally call e.stopPropagation(), which now only occurs if payload.value is truthy and editActive is false. This change allows click events to propagate under certain conditions where they previously would not have. Additionally, the formatting of the LabelContainer component's props has been adjusted for improved readability. There are no alterations to the declarations of exported or public entities in this update.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fe8d4ad and b816bcb.

📒 Files selected for processing (1)

• packages/suite/src/components/suite/labeling/MetadataLabeling/MetadataLabeling.tsx (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• packages/suite/src/components/suite/labeling/MetadataLabeling/MetadataLabeling.tsx

⏰ Context from checks skipped due to timeout of 90000ms (5)

• GitHub Check: run-e2e-suite-desktop-tests (@group=wallet, trezor-user-env-unix bitcoin-regtest)
• GitHub Check: run-e2e-suite-desktop-tests (@group=passphrase, trezor-user-env-unix)
• GitHub Check: Analyze with CodeQL (javascript)
• GitHub Check: build-web
• GitHub Check: Setup and Cache Dependencies

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[komret]

Thanks! Coin control works fine. Ssome comment in the code explaining the conditions might be helpful to prevent us from breaking it again.