Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(suite-native): FW update in onboarding flow #17134

Merged
merged 3 commits into from
Feb 21, 2025
Merged

feat(suite-native): FW update in onboarding flow #17134

merged 3 commits into from
Feb 21, 2025
+304 −229

Conversation

PeKne
Copy link
Contributor

@PeKne PeKne commented Feb 20, 2025

Description

  • Update of FW for seedless device added to the onboarding flow
    • there is a separate ConfirmFirmwareUpdate screen for both onboarding flow and device settings
    • these two screen share the UI and device handling via the ConfirmFirmwareUpdateContent component

How to test it:

  1. enable device onboarding feature flag
  2. connect factory device that does not hold seed, but have the FW installed (not the latest!)
  3. go through the onboarding flow, you should be able to update the FW to latest version or skip this actions (if you skip it, notting happens so far, later it will navigate to autheticity check screen)

Related Issue

Resolve #16431

Screenshots:

  • no screenshots needed the UI looks the same as in device settings FW update

@coderabbitai ignore 🐰 ☠️

@PeKne PeKne added the mobile Suite Lite issues and PRs label Feb 20, 2025
@PeKne PeKne requested a review from Nodonisko February 20, 2025 13:30
@PeKne PeKne requested a review from a team as a code owner February 20, 2025 13:30
@PeKne PeKne merged commit 198d6f4 into develop Feb 21, 2025
33 of 36 checks passed
@PeKne PeKne deleted the feat/native/onboarding-fw-update branch February 21, 2025 11:58
@martykan
Copy link
Member

Simulator Screenshot - iPhone 16 - 2025-03-12 at 16 50 31

@PeKne TODO is still there

@PeKne
Copy link
Contributor Author

PeKne commented Mar 12, 2025

It is expected. this message just informs you that next screen in not implemented yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nodonisko Nodonisko Nodonisko approved these changes

Assignees
No one assigned
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onboarding - Firmware Already Installed
3 participants
@PeKne @martykan @Nodonisko